Merge pull request #1539 from o1-labs/add-criterion-benchmarks

Convert unused ledger binary to proper criterion benchmarks

Author: dannywillems

.github/workflows/build-reusable.yaml

@@ -131,6 +131,33 @@ jobs:
       - name: Build tests
         run: make build-tests-webrtc
 
+  build-benches:
+    needs: [build]
+    timeout-minutes: 60
+    runs-on: ${{ inputs.os }}
+    env:
+      RUSTFLAGS: "-C overflow-checks=off -C debug-assertions=off ${{ inputs.rustflags }}"
+    steps:
+      - name: Git checkout
+        uses: actions/checkout@v5
+
+      - name: Setup build dependencies
+        uses: ./.github/actions/setup-build-deps
+
+      - name: Use shared OCaml setting up steps
+        uses: ./.github/actions/setup-ocaml
+        with:
+          ocaml_version: ${{ inputs.ocaml_version }}
+
+      - name: Setup Rust
+        uses: ./.github/actions/setup-rust
+        with:
+          toolchain: 1.84
+          cache-prefix: build-${{ inputs.os }}-${{ inputs.cache-prefix }}v0
+
+      - name: Build benchmarks
+        run: make build-benches
+
   build-wasm:
     if: ${{ inputs.build-wasm }}
     timeout-minutes: 60

.github/workflows/test-docs-scripts.yaml

@@ -221,6 +221,29 @@ jobs:
           # We'll just check if it was installed via Homebrew
           docker --version || echo "Docker installed but not running (expected on macOS CI)"
 
+  test-benchmark-commands:
+    name: Verify Benchmark Commands
+    runs-on: ubuntu-latest
+    if: github.event_name == 'schedule' || github.event_name == 'workflow_dispatch' || contains(github.event.pull_request.labels.*.name, 'test-doc-scripts')
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v5
+
+      - name: Verify benchmark scripts and commands
+        run: |
+          # Check if scripts exist and are executable
+          test -x ./website/docs/developers/scripts/benchmarks/build-benchmarks.sh
+          test -x ./website/docs/developers/scripts/benchmarks/run-all-benchmarks.sh
+          test -x ./website/docs/developers/scripts/benchmarks/run-database-benchmark.sh
+
+          # Verify the make targets referenced in scripts exist in Makefile
+          grep -q "^build-benches:" Makefile
+          grep -q "^bench:" Makefile
+          grep -q "^bench-database:" Makefile
+
+          echo "SUCCESS: All benchmark commands verified"
+
   test-update-ocaml-node-script:
     name: Test Update OCaml Node Script
     runs-on: ${{ matrix.os }}

CHANGELOG.md

@@ -75,6 +75,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#1528](https://github.com/o1-labs/mina-rust/pull/1528/))
 - **Codebase**: remove unused `ledger/src/poseidon/fp.rs` file
   ([#1538](https://github.com/o1-labs/mina-rust/pull/1538))
+- **Ledger**: convert unused binary to proper criterion benchmarks. Benchmarks
+  are now built as part of the existing build workflows across all platforms,
+  reusing build caches for efficiency
+  ([#1539](https://github.com/o1-labs/mina-rust/pull/1539))
 
 ## v0.17.0