-
Notifications
You must be signed in to change notification settings - Fork 47
No longer works for SuperCollider? #55
Comments
That's the least useful issue we've had in a while, could you at least try to fill in the forms and add valuable information into the issues ? We can't do anything without context. |
There are no forms for this repo and so nothing to fill out. That said, I understand that a lack of context isn't helpful. What would you like to know ? I'm using tree-sitter version 0.20.0 To replicate: |
Are you sure the |
yes. The strange thing is it used to work fine but all of a sudden it stopped, which is why I was curious if anything changed that would disable it by default or something for supercollider? |
I tried going back to an earlier version (commit 1bf0f79) but that didn't help, so maybe it isn't something in this plugin that changed after all. Any ideas what it could be? |
I have absolutely no idea, what does |
Seems alright:
|
I really don't know then |
@madskjeldgaard can you share the file you are using for testing? |
Can reproduce. Arch Linux
|
Here is a simple example:
Parses as
Using the cli tool The supercollider parser and nvim treesitter work fine otherwise. Code highlighting is correct, the parsing looks correct too behind the scenes, but there's just nothing happening when running playgrund |
Debugging this a bit now. Seems like it is the split function that is failing and that it might be connected to the window? WTF? if you uncomment this line:
The split opens with the parsed node tree. But then, when you jump back to the main window (where the buffer of the file to be parsed is) it closes the Playground split automatically? Here I am with the set window line uncommented, navigating the node tree and then jumping to the main buffer using C-w and then it disappears. |
Ah and then if you also comment out this line: Can some of the devs with more knowledge of what's going on here clarify what the issue might be? |
When I run the toggle playground command, this is the value of bufnr: 1 in the .open() method |
Something odd: the |
When opening TSPlaygroundToggle in a SuperCollider buffer M.attach is called, followed by M.detach followed by M.attach. This does not happen in .cpp. |
I can also reproduce. Arch Linux
and when commenting out nvim-treesitter-playground/internal.lua#L765 as suggested by @madskjeldgaard and to sum it up doing this: madskjeldgaard@854afcf |
So I bisected a bit and rolled back several times in the commit history of playground to see when I could get it to work. No luck. But I found something else which seems to be the real issue. |
Ah maybe this is about scnvim's filetype setting ?Get Outlook for Android
|
Aha! So a quick test with both nvim-tressiter and playground in "buddy/friends rollback"-mode. Now I'm at the latest commit on both repos as of 22 March 2021. It was def not enough to just rollback on Playground. Because now |
Maybe a combination, i remember we did some |
Okay the |
And it seems the issue is how the -- notes on using playground while having scnvim installed
-- 9be9ebd seems to break playground usage with sc filetype or at least trigger something which is broken in scnvims detect sys
commit = "74d1d58572a0e017aacb3fb66b43add9d208b86e", -- Jul 18, 2021 working
commit = "9be9ebda0ad5d5ffb880829ad3315ab7c55a2acc", -- Jul 18, 2021 not working |
Yes without scnvim installed I can now use But I do get errors without the scnvim plugin installed when scala short form is detected and rules all. At least there is some buggy behavior in regard to the supercollider filetype and scala detection even without the scnvim plugin. Soo maybe this is something nvim-treesitter have to deal with, the the same way Okay this is easier to show by making a list consisting of setup and result. An up to date treesitter, nvim and playground, including all maintained parsers installed
with scnvim installed
without scnvim
|
Looking into the new API with filetype.lua (in version 0.7.0). Then all of this may not even be a problem. Potential RIP hours :) |
Hello
All of a sudden, playground stopped working for supercollider files. Did you disable supercollider somehow? In other languages like python it works fine. But running
:TSPlaygroundToggle
in a supercollider buffer (.scd
) no longer does anythingThe text was updated successfully, but these errors were encountered: