Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gulpfile and Gruntfile incorrect icon #456

Closed
RafaelAntonny opened this issue Apr 29, 2024 · 12 comments · Fixed by #459
Closed

Gulpfile and Gruntfile incorrect icon #456

RafaelAntonny opened this issue Apr 29, 2024 · 12 comments · Fixed by #459

Comments

@RafaelAntonny
Copy link
Contributor

image

I'm using Lazy as my package manager devicons is a dependency for these following plugins that I have downloaded lualine, telescope and nvim-tree.
I already did a set_icon() for gulp I was able to change the icon but I wasn't able to change the color.
image
this is the result when I do a get_icon and a print
image
I already tried to make devicons load faster by putting it in a after/plugins folder which did make it load ahead of the plugins that are dependant on devicons but that didn't fix my problem, the icon is still the JS icon.

@alex-courtis
Copy link
Member

Lazy loading is problematic.

Please try and reproduce using the minimal nvim-tree bug report template as per #455 (comment)

@RafaelAntonny
Copy link
Contributor Author

Like just setup({}) for nvim-tree right ? I just did that nothing has changed
image
Also, my mistake, its not only nvim-tree that is having the problem with the incorrect icons telescope, bufferline (didn't mention before because I forgot) are also having that problem, I don't use the file icons for lualine so I cannot tell if its having the same issue but ig its a safe bet to say it does.
image
image
I did try override the icon again a little earlier, it did work with the colors and everything but only after I changed from 'gulpfile' to 'gulpfile.js'

@RafaelAntonny
Copy link
Contributor Author

RafaelAntonny commented Apr 29, 2024

I forgot to mention, after you pointed out the lazy loading I turned lazy loading for all of these plugins that are dependant on devicon to see if any of them were interfering with devicons loading, no success there

update: changed devicons priority to 1000 and dependants priority to 0, no effects
image

@alex-courtis
Copy link
Member

There's a lot going on there; please try a minimal config without lazy.

@RafaelAntonny
Copy link
Contributor Author

Sorry for the delay, was figuring out how to install plugins with packer lol.
image
this is packer, minimal neovim install

@alex-courtis
Copy link
Member

this is packer, minimal neovim install

Excellent. Please share so that we can reproduce.

@RafaelAntonny
Copy link
Contributor Author

RafaelAntonny commented Apr 29, 2024

aye, this repo here has the files if it isn't a problem

@alex-courtis
Copy link
Member

aye, this repo here has the files if it isn't a problem

Sorry, I'm not going to debug your configuration.

Minimal configuration as requested please. We'll be mandating that soon: #457

@RafaelAntonny
Copy link
Contributor Author

RafaelAntonny commented Apr 30, 2024

image

for name, url in pairs{
  devicons = 'https://github.com/nvim-tree/nvim-web-devicons',
  nvimtree = 'https://github.com/nvim-tree/nvim-tree.lua',
} do
  local install_path = vim.fn.fnamemodify('devicons_issue'..name, ':p')
  if vim.fn.isdirectory(install_path) == 0 then
    vim.fn.system { 'git', 'clone', '--depth=1', url, install_path }
  end
  vim.opt.runtimepath:append(install_path)
end

require('nvim-web-devicons').setup{}
require('nvim-tree').setup()

ran ofc with a nvim --clean -u minimal.lua, again I like to point out that this it not an issue that i'm having exclusively with nvim-tree but all other plugins that use devicons are also having the same issue
first time opening an issue, I apologize if I am being hard to work with

@alex-courtis
Copy link
Member

Don't stress, you're fine. We need to add our bug report template.

I like the minimal; that sounds like what we should use.

It looks to be working as intended: gulpfile and gruntfile files show their icons:
20240430_135208

Are those names correct?

@RafaelAntonny
Copy link
Contributor Author

interesting so it only works if it doesn't have the .js extension, hmm...
well the name is correct but the .js extension is nescessary
image
otherwise npm can't run it
image

You think this is an appropriate point to close the issue ?

@alex-courtis
Copy link
Member

Sounds like they're incorrect... pull requests are gratefully appreciated.

alex-courtis added a commit that referenced this issue May 4, 2024
…ypes (#459)

* expanding gulpfile and gruntfile icons to other filetypes

* running make

---------

Co-authored-by: Alexander Courtis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants