Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_active_clients is deprecated in nvim 0.10 #19

Closed
seocamo opened this issue May 22, 2024 · 0 comments
Closed

get_active_clients is deprecated in nvim 0.10 #19

seocamo opened this issue May 22, 2024 · 0 comments
Assignees

Comments

@seocamo
Copy link

seocamo commented May 22, 2024

NeoVim Version
NVIM v0.11.0-dev-45+g879d17ea8
Build type: RelWithDebInfo
LuaJIT 2.1.1713484068
Run "nvim -V1 -v" for more info

Describe the bug
get_active_clients is deprecated in version 0.10 and will be remove in 0.12, so it call notify and make popups.
the problem is on line 35 for _, client in pairs(vim.lsp.get_active_clients(filters)) do in lsp.lua

have to fix
replace vim.lsp.get_active_clients with (vim.lsp.get_clients or vim.lsp.get_active_clients) with the () is important as it will pick the new get_clients if found ellers fall back on the old get_active_clients for old versions.

so the line should look like this for _, client in pairs((vim.lsp.get_clients or vim.lsp.get_active_clients)(filters)) do

thanks for a great plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants