-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: File Nesting sometimes not working. #1494
Labels
bug
Something isn't working
Comments
I have this issue as well, did you find a fix? |
No. |
saifulapm
added a commit
to saifulapm/neo-tree.nvim
that referenced
this issue
Nov 16, 2024
…rules (nvim-neo-tree#1494) When multiple file nesting rules were configured, rules were being applied inconsistently. For example, sometimes when both `package.json` and `vite.config.*` rules existed, only one set of rules would be applied while the other would be ignored intermittently. Example configuration that was working inconsistently: ```lua { ['vite.config.*'] = { files = { '%.babelrc*', 'babel%.config%.*', 'postcss%.config%.*', 'tailwind%.config%.*', '%.env%.*', 'tsconfig%.*' }, pattern = 'vite%.config%.(.*)$' }, ['package.json'] = { files = { '%.browserslist*', 'bower%.json', 'package-lock%.json', 'yarn%.lock', '%.eslint*', '%.prettier*' }, pattern = 'package%.json$' } } ``` The fix modifies the nesting logic to: - Collect all matching rules before applying any nesting - Use file IDs to prevent duplicate nesting - Track nested status properly - Apply rules in a deterministic order This ensures that all configured nesting rules are applied consistently regardless of their order or complexity. Fixes nvim-neo-tree#1494
This PR #1602 will solve that issue.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Did you check docs and existing issues?
Neovim Version (nvim -v)
v0.10.0
Operating System / Version
macOS Sonoma 14.5 arm64
Describe the Bug
Hi, When I added large nesting rules tables, then sometimes nesting rules works and sometimes not. I understand that it's happening because of large table. Not sure it's possible to fix...
You can check video: In LazyVim folder, I have rules for readmes. sometime readmes nested sometime not.
Screen.Recording.2024-06-09.at.7.30.26.PM.mov
Here is those rules:
If I just added this rule no any other rule, then it works every time. So this issue happening because large table.
Thanks
Screenshots, Traceback
No response
Steps to Reproduce
git clone https://github.com/lazyVim/LazyVim/
and open in neovim. Sometime readmes nested sometimes not,Thanks
Expected Behavior
It should be nested every time. In the video, you can see what's happening.
Your Configuration
The text was updated successfully, but these errors were encountered: