Keep-going option for busted-style tests #197
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rish987
force-pushed
the
busted_keep_going
branch
from
162f9da to
9765aa8
Compare
rish987
force-pushed
the
busted_keep_going
branch
3 times, most recently
from
1cebffa to
d43df82
Compare
tjdevries
reviewed
Aug 9, 2021
lua/plenary/test_harness.lua
Outdated
| @@ -42,6 +42,8 @@ end | |||
| function harness.test_directory(directory, opts) | |||
| print "Starting..." | |||
| opts = vim.tbl_deep_extend("force", { winopts = { winblend = 3 } }, opts or {}) | |||
| local run_opts = vim.tbl_deep_extend("force", { keep_going = false }, opts.run_opts or {}) | |||
| local run_opts_string = vim.inspect(run_opts):gsub("\n", " ") | |||
There was a problem hiding this comment.
can we do json_encode and json_decode instead here?
There was a problem hiding this comment.
Done. Also there was a pretty blatant bug here that I somehow missed when testing (was misusing run below instead of replacing with run_command), fixed.
rish987
force-pushed
the
busted_keep_going
branch
from
d43df82 to
1de239f
Compare
rish987
force-pushed
the
busted_keep_going
branch
from
1de239f to
7d84fe1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #196.