Skip to content

pre-commit in the workflow #28

@hwf1324

Description

@hwf1324

Currently, the workflow's build process uses pre-commit for code linting, where pre-commit runs pyright checks and ruff auto-fixes. On one hand, the current pyright configuration might be too strict for Add-on code, making it difficult to fix or mark ignores for existing Add-ons. On the other hand, ruff auto-fixes also modify files.

Since the current pre-commit configuration includes a CI section, should we use pre-commit.ci? However, this seems to require configuration by the Add-on authors.

As a secondary option, we could use pre-commit/action in a standalone workflow to perform code checks, ensuring that the Add-on always builds.

As a side note, I have tried using the --from-ref FROM_REF + --to-ref TO_REF parameters, but in some cases, it still runs on all files.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions