-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot read properties of undefined (reading 'cdnURL') #753
Comments
@AlexanderBredun did you manage to find a workaround? |
@guim4dev no unfortunately |
To replicate, build the showcase app that has
Go to the build folder ( Check the logs in the console. |
Thanks @obulat for the reproduction. I get the error there now as well. This only occurs in the static build, and not when looking in console for the dev build ( That makes debugging this a bit harder... |
I think that this is related to #761, and the errors there can be masking these errors. router is definitely part of the problem here. |
I have a similar problems. Occurs with the autogenerated Docs view when I have multiple exports in a stories file. |
adding some extra info here @doppelmutzi I had the same problem. It only occurs in autogenerated docs with >1 stories. Single Story autogenerated docs work fine, its probably something related to routing as pointed out by @obulat I disabled autodocs for now as multi stories are important for our use case and it works fine locally. Sadly now im getting blocked by chromatic, as the built version of storybook also throws the cdnURL error :/ |
Could this be a race condition? I set a breakpoint on line 2 in paths.mjs and then stepped into // /.nuxt/nitro.client.mjs
export const useRuntimeConfig = () =>
window?.__NUXT__?.config || {} In However, when I later check whether this global variable is defined in the console I can see that it is: |
@tobiasdiez Thank you for your work on this module 💚 It would be great to prioritise this issue. In my case I can't upgrade to Nuxt 3.13.x because of this error. I will also try to investigate. |
Encountered this error with latest versions of nuxt and storybook.
Come to think of it, this is probably related to other issue, but still might be useful to someone |
Thanks for looking into this. If it's indeed a problem with the runtime bundler of vue, then this should be fixed as part of #740 (which sadly is stuck in another issue). |
As a workaround, because we are not using cdn or changing the base URL, diff --git a/dist/index.mjs b/dist/index.mjs
index 9fe137cf72916a0ceb3edbae12c9deacd960faed..625bb157338fbf10083760166600e518d81065c5 100644
--- a/dist/index.mjs
+++ b/dist/index.mjs
@@ -5119,7 +5119,8 @@ const publicPathTemplate = {
"export const buildAssetsDir = () => appConfig.buildAssetsDir",
"export const buildAssetsURL = (...path) => joinRelativeURL(publicAssetsURL(), buildAssetsDir(), ...path)",
"export const publicAssetsURL = (...path) => {",
- " const publicBase = appConfig.cdnURL || appConfig.baseURL",
+ " const publicBase = ''",
" return path.length ? joinRelativeURL(publicBase, ...path) : publicBase",
"}",
// On server these are registered directly in packages/nuxt/src/core/runtime/nitro/renderer.ts
|
When you use Storybook's render function to render out a component (or components) this issue arises as well. |
@d-low for me I've been doing some tests and the function passed to the I'm having trouble understanding how the 2 packages work together. I know that the Nuxt renderer is a wrapper for Does anyone have an idea of what's happening? |
Reverting commit bcf68df stops the error, but images are broken, maybe it's just a matter of adding Ok, so temporary workaround for anyone struggling with this. Add this snippet to your // @ts-expect-error internal Nuxt property
window.__NUXT__ = {
config: {
app: {
baseURL: '/',
cdnURL: ''
}
}
} And to make images work, add this line to your config in staticDirs: ['../public'], |
Looks like this error is not showing up when I remove |
I used this Nuxt Storybook starter, but when I try to add any image from the public directory, I get the following error:
When I checked the console, it pointed me to this part of the code and showed that there is a problem with useRuntimeConfig:
Node 18.18.2, npm 9.8.1, windows 10
The text was updated successfully, but these errors were encountered: