Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install Chromatic github app #710

Open
tobiasdiez opened this issue Jul 13, 2024 · 4 comments
Open

Install Chromatic github app #710

tobiasdiez opened this issue Jul 13, 2024 · 4 comments
Assignees
@chakAs3
Labels
type: chore Helpful for the development of this module

Comments

@tobiasdiez
Copy link
Collaborator

In order to get feedback about the build status in Chromatic of the automatically deployed examples, we need to install the Chromatic App.

@chakAs3 @danielroe @atinux I don't have sufficient rights to install the chromatic app, but have requested it to be installed in the nuxt-modules org. Could you please activate it? Thanks!
@tobiasdiez tobiasdiez added the type: chore Helpful for the development of this module label Jul 13, 2024
@chakAs3 chakAs3 self-assigned this Jul 13, 2024
@danielroe
Copy link
Collaborator

Done ✅

@tobiasdiez
Copy link
Collaborator Author

Thanks a lot!

Apparently, one also needs oauth integration in order to link github repo to the project. I hope I can configure it once the initial permission has been setup. Could you please do this at https://github.com/settings/connections/applications/495b5c3cb5ae140436a0 ?

@tobiasdiez tobiasdiez reopened this Jul 13, 2024
@danielroe
Copy link
Collaborator

Approved again.

@tobiasdiez
Copy link
Collaborator Author

tobiasdiez commented Aug 22, 2024 •
edited
Loading

Thanks @danielroe. It is however still not working. I'm in contact with the Chromatic support to resolve the situation. Could you please confirm that the following apps are installed in the nuxt-modules org?

Chromatic OAuth app > here.
Chromatic.com app > here.

For me the first link says that "Access request pending" under the nuxt-modules org.

I believe the problem comes from the fact that in Chromatic the project is under my private account, and I'm not officially part of the nuxt-modules org. Would it be possible to invite me there (not sure what permissions are needed). We can also talk about this via email: [email protected]

@tobiasdiez tobiasdiez mentioned this issue Jan 16, 2025
Merged
tobiasdiez added a commit that referenced this issue Jan 16, 2025
@tobiasdiez
chore: fail workflow if chromatic finds changes in examples (#843)
e0a87cf 
<!--
☝️ PR title should follow conventional commits
(https://conventionalcommits.org).
In particular, the title should start with one of the following types:

- docs: 📖 Documentation (updates to the documentation or readme)
- fix: 🐞 Bug fix (a non-breaking change that fixes an issue)
- feat: ✨ New feature/enhancement (a non-breaking change that adds
functionality or improves existing one)
- feat!/fix!: ⚠️ Breaking change (fix or feature that would cause
existing functionality to change)
- chore: 🧹 Chore (updates to the build process or auxiliary tools and
libraries)
-->

Currently the workflow passes even though there are changes in the
examples. Thus, one always have to manually check the chromatic app
before merging a PR, which gets tiresome.

### 🔗 Linked issue

Refs #710

<!-- If it resolves an open issue, please link the issue here. For
example "Resolves #123" -->

### 📚 Description

<!-- Describe your changes in detail -->
<!-- Why is this change required? What problem does it solve? -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chakAs3 chakAs3

Labels
type: chore Helpful for the development of this module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chakAs3 @tobiasdiez @danielroe