Skip to content
This repository has been archived by the owner on May 20, 2024. It is now read-only.

isEligible should fire on route change #3

Open
uptownhr opened this issue Sep 28, 2018 · 3 comments
Open

isEligible should fire on route change #3

uptownhr opened this issue Sep 28, 2018 · 3 comments

Comments

@uptownhr
Copy link

Maybe I'm not understanding the intent of isEligible but I feel this should be continuously checked as route is being changed. Resulting in a experiment being able to be inactive until a user reaches a certain route.
@pi0
Copy link
Member

pi0 commented Sep 28, 2018

PRs welcome for this enhancement :)

@japboy japboy mentioned this issue Mar 5, 2019
Closed
@kwolniak
Copy link

kwolniak commented Feb 3, 2021 •
edited
Loading

I would love to see this feature works with route change, for now isEligible looks usless.

@farzadso
Copy link
Collaborator

farzadso commented Feb 4, 2021

@kwolniak Someone started a PR for it a while ago: #7

It would be great if you could continue the whole idea.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kwolniak @uptownhr @pi0 @farzadso