Default completer doesn't complete blank lines

[6z7y]

please update example and add MenuBuilder is required
and in tab-complete i got this is not work

  "test".into(),
  "hello world".into(),
  "hello world reedline".into(),
  "this is the reedline crate".into(),

or i can't select what i want from it

this only i want fix it

[ysthakur]

The default completer won't show you anything until you start typing. Try typing h<TAB>, then you should see suggestions.

If your problem is something else, please show us your code and what you're trying to do in the REPL, because it's hard to diagnose problems without that information.

[6z7y]

ok take

main.rs:

use reedline::{default_emacs_keybindings, Signal, DefaultPrompt, MenuBuilder, ColumnarMenu, DefaultCompleter, Emacs, KeyCode, KeyModifiers, Reedline, ReedlineEvent, ReedlineMenu};

fn main() {
    let commands = vec![
      "test".into(),
      "hello world".into(),
      "hello world reedline".into(),
      "this is the reedline crate".into(),
    ];
    let completer = Box::new(DefaultCompleter::new_with_wordlen(commands.clone(), 2));
    // Use the interactive menu to select options from the completer
    let completion_menu = Box::new(ColumnarMenu::default().with_name("completion_menu"));
    // Set up the required keybindings
    let mut keybindings = default_emacs_keybindings();
    keybindings.add_binding(
        KeyModifiers::NONE,
        KeyCode::Tab,
        ReedlineEvent::UntilFound(vec![
            ReedlineEvent::Menu("completion_menu".to_string()),
            ReedlineEvent::MenuNext,
        ]),
    );

    let edit_mode = Box::new(Emacs::new(keybindings));

    let mut line_editor = Reedline::create()
        .with_completer(completer)
        .with_menu(ReedlineMenu::EngineCompleter(completion_menu))
        .with_edit_mode(edit_mode);
    let prompt = DefaultPrompt::default();

    loop {
        let sig = line_editor.read_line(&prompt);
        match sig {
            Ok(Signal::Success(buffer)) => {
                println!("We processed: {}", buffer);
            }
            Ok(Signal::CtrlD) | Ok(Signal::CtrlC) => {
                println!("\nAborted!");
                break;
            }
            x => {
                println!("Event: {:?}", x);
            }
        }
    }
}

---

i take it from example

and should be show me in tab-complete like this:
"test".into(),
"hello world".into(),
"hello world reedline".into(),
"this is the reedline crate".into(),

but not work with me

[ysthakur]

I can't reproduce this. I ran your code using the latest commit to Reedline and got suggestions:

Note that if you hit tab without typing anything, the default completer won't give you any completions. But if you type h or t or something, then you should see completions. Can you try doing that and let me know if you still don't see any suggestions?

[6z7y]

ohh, i see but i want if empty prompt type show me all suggestions, i can doing this?

[ysthakur]

I made a PR for fixing this (#923), so you could wait for the next release. If you don't want to wait, you could also take the default completer from my branch in that PR and copy it to your codebase.

A third option would be to make your own little completer. For example, if you're fine with a simple completer that provides suggestions that start with whatever the user has typed, then this might work for you:

struct MyCompleter {
    pub commands: Vec<String>,
}
impl Completer for MyCompleter {
    fn complete(&mut self, line: &str, pos: usize) -> Vec<Suggestion> {
        let line = &line[..pos];
        self.commands
            .iter()
            .filter(|cmd| cmd.starts_with(line))
            .map(|cmd| Suggestion {
                value: cmd.to_string(),
                span: Span::new(0, pos),
                ..Default::default()
            })
            .collect()
    }
}

[6z7y]

i will wait and thanks