Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caps Lock ignored on Windows #360

Open
TyPR124 opened this issue Mar 23, 2022 · 2 comments
Open

Caps Lock ignored on Windows #360

TyPR124 opened this issue Mar 23, 2022 · 2 comments
Labels
A-Events Area: Handling of incoming events (e.g. desired keypress not registered) bug Something isn't working P-high High Priority: Annoying bug, should be addressed with the next release platform-dependent Issue that can only be observed on certain platforms or terminal emulators

Comments

@TyPR124
Copy link

TyPR124 commented Mar 23, 2022

Describe the bug

On my system, caps lock is ignored. Typing with caps lock on produces lower case. Holding shift with caps lock on produces upper case.

This seems to only affect Windows. I do not get the same behavior in WSL.

All within the same window, I can switch between various shells like cmd, pwsh, and nu - and nu is the only one to ignore caps lock.

How to reproduce

  1. Have Windows
  2. Unsure if it is specific to Windows 10 and/or the new console window
  3. Have Caps Lock enabled
  4. Type stuff

Expected behavior

I expected nu to respect my caps lock key state.

Screenshots

No response

Configuration

key value
version 0.60.0
build_os windows-x86_64
rust_version rustc 1.59.0 (9d1b2106e 2022-02-23)
rust_channel stable-x86_64-pc-windows-msvc
cargo_version cargo 1.59.0 (49d8809dc 2022-02-10)
pkg_version 0.60.0
build_time 2022-03-22 22:19:26 -04:00
build_rust_channel release
features dataframe, default, trash, which, zip
installed_plugins

Additional context

OS Version: 10.0.19042 N/A Build 19042

@fdncred
Copy link
Collaborator

fdncred commented Mar 23, 2022

confirmed. the same thing happens to me on windows with windows terminal with caps lock on. this could be a reedline issue?

@fdncred fdncred added the bug Something isn't working label Mar 23, 2022
@elferherrera
Copy link
Contributor

I knew this one was going to bite us back. In reedline we decided to case ignore all inputs and change the case based on the modifier. It seems that caps dont send a modifier to the events.

@sholderbach sholderbach transferred this issue from nushell/nushell Mar 25, 2022
@sholderbach sholderbach added A-Events Area: Handling of incoming events (e.g. desired keypress not registered) P-high High Priority: Annoying bug, should be addressed with the next release platform-dependent Issue that can only be observed on certain platforms or terminal emulators and removed line editor priority labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Events Area: Handling of incoming events (e.g. desired keypress not registered) bug Something isn't working P-high High Priority: Annoying bug, should be addressed with the next release platform-dependent Issue that can only be observed on certain platforms or terminal emulators
Projects
None yet
Development

No branches or pull requests

5 participants