Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How about nushell-completions? #598

Open
otakutyrant opened this issue Sep 10, 2023 · 5 comments
Open

How about nushell-completions? #598

otakutyrant opened this issue Sep 10, 2023 · 5 comments

Comments

@otakutyrant
Copy link

There are bash-completion and zsh-completions already. I think it is convenient to regard the present custom-complitions as an individual package to distribute or install.

@fdncred
Copy link
Collaborator

fdncred commented Sep 10, 2023

Seems like this is a nupm type of request?

@otakutyrant
Copy link
Author

I am not familiar with nupm but bash-completion and zsh-completions can be installed in many linux distributions with their each internal package manager.

@fdncred
Copy link
Collaborator

fdncred commented Sep 10, 2023

Nupm is our unfinished package manager. https://github.com/nushell/nupm.

We also have to be cross-platform, where would these files go on Windows?

@otakutyrant
Copy link
Author

At least, nushell-completions should be an individual package to package, distibute, and install. How to package it does not matter here, and whether to install the package with nupm is up to users, but I wager that Unix users prefer to install the package with the operation system package manager instead. As for Windows users, they can use nupm anyway, if nupm supports it.

@amtoine
Copy link
Member

amtoine commented Sep 10, 2023

on linux, i would still use nupm to install this, which is what i'm doing in my current config, i guess we would just need to make the custom-completion/ directory a package instead of the whole nu_scripts repo 😋

see the package.nuon file 😉

right now you can nupm install --path /path/to/nu_scripts/ and have all the nu_scripts installed, but i can imagine doing nupm install --path /path/to/nu_scripts/custom-completions/ instead 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants