Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAVLink XML change to allow exponentiation operator in bitmask flag #11

Closed
hamishwillee opened this issue Feb 26, 2024 · 1 comment · Fixed by #20
Closed

MAVLink XML change to allow exponentiation operator in bitmask flag #11

hamishwillee opened this issue Feb 26, 2024 · 1 comment · Fixed by #20

Comments

@hamishwillee
Copy link

hamishwillee commented Feb 26, 2024

FYI We're modifying the MAVLink XSD validation file in ArduPilot/pymavlink#920 to allow a bitmask value to be declared using the Python exponentiation operator.

This makes it easier to immediately visualize which bit is set by a flag, because you can use the syntax

<entry value="2**15" name="BIT15" />

rather than

<entry value="32768" name=" BIT15" />

This is transparent to mavgen because the parser evaluates the number before creating the generated headers. However it may affect other parsers.
We're not updating the XML yet to allow other parsers time to update.

Any concerns, please raise on ArduPilot/pymavlink#920

@wdueease
Copy link
Contributor

wdueease commented Nov 1, 2024

I use a lot of bitmasks so I took a stab at this since it seems useful. Feedback appreciated!

@nus nus closed this as completed in #20 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants