Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address with Invalid Address Allwoed #5783

Open
nus-pe-bot opened this issue Nov 11, 2022 · 1 comment
Open

Address with Invalid Address Allwoed #5783

nus-pe-bot opened this issue Nov 11, 2022 · 1 comment
Labels
response.Rejected severity.Low status.Done team.3 tutorial.CS2103T-W09 type.FeatureFlaw

Comments

@nus-pe-bot
Copy link

nus-pe-bot commented Nov 11, 2022 •
edited by TJun-Jie
Loading

image.png

An invalid address consisting of only numbers is allowed

To recreate:

  1. add n/test p/11111111 e/test@gmail a/11111111111 adds n "address" with consisting of only numbers
[original: nus-cs2103-AY2223S1/pe-interim#5776] [original labels: type.FeatureFlaw severity.Medium]
@TJun-Jie
Copy link
Contributor

TJun-Jie commented Nov 13, 2022 •
edited
Loading

Team's Response

It is overzealous to implement address validation as addresses tend to come in all kinds of format. Also, providing invalid address input is considered extreme user behaviour.

telegram-cloud-photo-size-5-6305122938579431772-y.jpg/Users/tjunjie/Library/Group Containers/6N38VWS5BX.ru.keepcoder.Telegram/stable/account-2102874230587161628/postbox/media/telegram-cloud-photo-size-5-6305122938579431772-y.jpg

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
response.Rejected severity.Low status.Done team.3 tutorial.CS2103T-W09 type.FeatureFlaw
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nus-pe-bot @TJun-Jie