Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue] Fix email issues #3200

Open
sync-by-unito bot opened this issue Feb 5, 2024 · 10 comments
Open

[issue] Fix email issues #3200

sync-by-unito bot opened this issue Feb 5, 2024 · 10 comments

Comments

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 5, 2024

✓ Receive two different emails after minting NFT via Dashboard

┆Issue is synchronized with this Asana task by Unito
┆Created By: Sam

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Sam commented:

Ethan Wu, I have a question

Sherry Chung asked that wether [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737 ) can be delivered in v240206-capture-cam-ionic-internal ( https://app.asana.com/0/1201016280880500/1206491967244628/f )?

However I want to identify first which product this issue belongs to capture-cam-ionic, capture-cam-iframe or capture-cam-dashboard.

In Receive two different emails after minting NFT via Dashboard ( https://app.asana.com/0/1201016280880500/1206415038646327/f )user mentioned that s/he "Receive two different emails after minting NFT via Dashboard".

Originally I assumed it might be capture-cam-iframe task since "Network actions" in capture-cam-ionic are implemented in bubble side (aka capture-cam-ionic). But since user mint via Dashboard I believe [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737 ) is more of a Dashboard task?

So in summary

  1. Is [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737 ) can be fixed from capture cam Dashboard or backend task (not sure how mint & share happens in Dashboard side) ?
  2. Should we do any changes in capture-cam-iframe side?

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Sherry Chung commented:

Scott Yan I think QA had confirmed that the issue also happened when user mint & share Capture in Capture Cam. Can you provide more information to Sam?

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Scott Yan commented:

Sam ( cc Ethan WuSherry ChungKenny Hung )

  1. Please first confirm whether the following two methods are using captureclub workflow

a. in the edit page ( list capture for sale )

b. network action ( mint and share )

  1. if yes , please wait the dashboard workflow pass qa & deploy , than do 3 step

if no , Please provide what process was used and suggest corrections

  1. make sure dashboard workflow pass qa & deploy to live . than change the workflow ( captureclub workflow ) to the new workflow ( dashboard workflow )

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Sam commented:

Scott Yan, I checked capture-cam-ionic source code and previous asana conversations.

For 1a. need to confirm with Ethan Wu (it's done on bubble side currently I have no access capture-cam-iframe)

IMG_2221.jpg

For 1b. mint & share it it uses capture-cam-ionic. And since source code ( https://github.com/numbersprotocol/capture-lite/blob/master/src/app/features/home/details/actions/action-details/action-details.page.ts#L185 ) for network actions (including mint & share) haven't changed since 2022 Comment by @ray Hung on [FR] list to capture finish 要讓 user 知道該張 capture 已經 list 過 ( https://app.asana.com/0/0/1201558520076805/1201995911008176/f ) I believe it's still uses "captureclub workflow".

IMG_2220.jpg

I'm not familiar with "dashboard workflow" so let me consult with Ethan Wu on that first.

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Ethan Wu commented:

I've checked the captureclub workflow before and I don't think there is an email. When I get to my computer I can check to see if iframe as any email items

Copy link
Author

sync-by-unito bot commented Feb 5, 2024

➤ Ethan Wu commented:

these are the workflows from captureclub. as you can see there are no send email steps.

Copy link
Author

sync-by-unito bot commented Feb 6, 2024

➤ Sam commented:

Ethan Wu thank you for confirming 1.b

Scott Yan (cc: Kenny Hung) do we need to send email when user "Mint & Share" from Capture Cam (Edit page)?

Copy link
Author

sync-by-unito bot commented Feb 6, 2024

➤ Kenny Hung commented:

Sam (cc Scott YanEthan Wu)

As I know, v240201-dashboard bubble workflow doesn't send email when user mint & share, just rely on backend side when list on explore page.

  1. Please check dashboard workflow
  2. Mint & share on network action & List Capture for Sale, the result should be the same.

Copy link
Author

sync-by-unito bot commented Feb 6, 2024

➤ Sam commented:

Kenny Hung thank you for clarification.

  1. Regarding 1. I don't have access to dashboard workflow therefore Ethan Wu can you please let me know
    1. what API is called from Dashboard when user do "Mint & Share" (I saw it passed QA testing ( https://app.asana.com/0/0/1206415038646327/1206518277335329/f ) 🎉).
    2. How dashboard checks if assets is already minted or not? Reason I ask this because ionic side it applies some workaround ( https://github.com/numbersprotocol/capture-lite/blob/master/src/app/features/home/details/actions/action-details/action-details.page.ts#L187 ) that was discussed in Comment by @ray Hung on [FR] list to capture finish 要讓 user 知道該張 capture 已經 list 過 ( https://app.asana.com/0/1201016280880500/1201558520076805/1201995911008176/f ) around 2022.

  2. Regarding 2.
    1. Mint & Share from Network Actions Page is done from ionic side.
    2. List Capture for Sale from Edit Page is done from iframe side.

I tried 2.a & 2.b they both work same and send 2 emails. These email were received when I tried via 2.b (List Capture for Sale)

Dear creator,

Your Capture (bafkreiewa6vzzljylvrkf6qeka7bnyahvari5723j7mspqn7nzs4oahjw4 ( http://mailman.numbersprotocol.io/ls/click?upn=EGxa1LLkHtsMOSkmrpU78kL6GJPtSpGjSn5r5Sj6aiPkpCgwc-2B51wikyZyB23Gd8VH5T0e1ESMKFOlQ973lpoUdlpdoh46UtrG-2BcfKro1pm-2F4KF50hwSCnWMGBuflWC47QYMIMvoQ-2FzU3-2Fp-2BwLELJQ-3D-3Dam-O_8vLrht0VxUnpefWHGNJcHJeGYutsN3fk2BYMhboS-2Bp7fkEu3008BGxBJUCmGWJp0gX0ehzefi96TirF3OFwdMXm3Z-2Fpe5yadVD-2F0v929uK6cZ5zqGliQnPealF1wHcvf91l7UggpB626QQe-2B9OhmrZg3HjcKduvUuoq7fKalAVRFM9kTGwrfOynaubJw2X-2B9-2B4P9F4h2U5Y4zG2OAZC4jw-3D-3D )) has been listed on the Capture Explore page and shared with all Capture community members! It’s ready to be collected!.

Dear creator,

Your Capture (bafkreiewa6vzzljylvrkf6qeka7bnyahvari5723j7mspqn7nzs4oahjw4 ( http://mailman.numbersprotocol.io/ls/click?upn=EGxa1LLkHtsMOSkmrpU78kL6GJPtSpGjSn5r5Sj6aiPkpCgwc-2B51wikyZyB23Gd8VH5T0e1ESMKFOlQ973lpoUdlpdoh46UtrG-2BcfKro1pm-2F4KF50hwSCnWMGBuflWC47QYMIMvoQ-2FzU3-2Fp-2BwLELJQ-3D-3Dam-O_8vLrht0VxUnpefWHGNJcHJeGYutsN3fk2BYMhboS-2Bp7fkEu3008BGxBJUCmGWJp0gX0ehzefi96TirF3OFwdMXm3Z-2Fpe5yadVD-2F0v929uK6cZ5zqGliQnPealF1wHcvf91l7UggpB626QQe-2B9OhmrZg3HjcKduvUuoq7fKalAVRFM9kTGwrfOynaubJw2X-2B9-2B4P9F4h2U5Y4zG2OAZC4jw-3D-3D )) has been listed on the Capture Explore page and shared with all Capture community members! It’s ready to be collected!.

Kenny Hung (cc: Sherry Chung)

In summary to fix [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737 ) we need to do changes in

  1. ionic side
    1. Once I know more on how Mint & Share is done on Dashboard side I will try to migrate/copy the logic to ionic side or do similar steps.

  2. iframe side
    1. need to do similar changes in iframe side

Copy link
Author

sync-by-unito bot commented Feb 6, 2024

➤ Sherry Chung commented:

Sam For your questions

"do we need to send email when user "Mint & Share" from Capture Cam (Edit page)?"

I would say, if there is no such function for Capture Cam, then we also not discuss this now. We're discussing if an issue user occurred will also happening on Capture Cam. Not to discussing adding more feature to Capture Cam.

However, if Capture Cam currently will sending email to user. We should know if this will also cause the same issue with Dashboard ✓ Receive two different emails after minting NFT via Dashboard ( https://app.asana.com/0/0/1206415038646327/f/ )

If yes, the issue need to be fixed. (This is the same as what Scott mentioned in Comment by @scott Yan on [issue] Fix email issues ( https://app.asana.com/0/0/1206518981379737/1206518972047073/f ))

If no, then the same issue didn't happen on Capture Cam. Nothing need to be updated now. We can close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants