diff --git a/pkg/apis/numaflow/v1alpha1/const.go b/pkg/apis/numaflow/v1alpha1/const.go index 9bae9004ed..090567072c 100644 --- a/pkg/apis/numaflow/v1alpha1/const.go +++ b/pkg/apis/numaflow/v1alpha1/const.go @@ -136,7 +136,6 @@ const ( EnvCPULimit = "NUMAFLOW_CPU_LIMIT" EnvMemoryRequest = "NUMAFLOW_MEMORY_REQUEST" EnvMemoryLimit = "NUMAFLOW_MEMORY_LIMIT" - EnvGoDebug = "GODEBUG" EnvServingMinPipelineSpec = "NUMAFLOW_SERVING_MIN_PIPELINE_SPEC" EnvK8sServerVersion = "K8S_SERVER_VERSION" EnvNumaflowRuntime = "NUMAFLOW_RUNTIME" diff --git a/pkg/apis/numaflow/v1alpha1/mono_vertex_types.go b/pkg/apis/numaflow/v1alpha1/mono_vertex_types.go index fedc9ac904..6a6f7c02e7 100644 --- a/pkg/apis/numaflow/v1alpha1/mono_vertex_types.go +++ b/pkg/apis/numaflow/v1alpha1/mono_vertex_types.go @@ -21,7 +21,6 @@ import ( "encoding/json" "errors" "fmt" - "os" "sort" "strconv" "time" @@ -230,7 +229,6 @@ func (mv MonoVertex) GetDaemonDeploymentObj(req GetMonoVertexDaemonDeploymentReq {Name: EnvNamespace, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.namespace"}}}, {Name: EnvPod, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.name"}}}, {Name: EnvMonoVertexObject, Value: encodedMonoVtx}, - {Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}, } envVars = append(envVars, req.Env...) c := corev1.Container{ diff --git a/pkg/apis/numaflow/v1alpha1/pipeline_types.go b/pkg/apis/numaflow/v1alpha1/pipeline_types.go index ba27e17851..a1f6da0781 100644 --- a/pkg/apis/numaflow/v1alpha1/pipeline_types.go +++ b/pkg/apis/numaflow/v1alpha1/pipeline_types.go @@ -20,7 +20,6 @@ import ( "encoding/base64" "encoding/json" "fmt" - "os" "strings" "time" @@ -251,7 +250,6 @@ func (p Pipeline) GetSideInputsManagerDeployments(req GetSideInputDeploymentReq) for i := 0; i < len(deployment.Spec.Template.Spec.Containers); i++ { deployment.Spec.Template.Spec.Containers[i].Env = append(deployment.Spec.Template.Spec.Containers[i].Env, commonEnvVars...) } - deployment.Spec.Template.Spec.InitContainers[0].Env = append(deployment.Spec.Template.Spec.InitContainers[0].Env, corev1.EnvVar{Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}) deployment.Spec.Template.Spec.Containers[0].Env = append(deployment.Spec.Template.Spec.Containers[0].Env, corev1.EnvVar{Name: EnvNumaflowRuntime, Value: "rust"}) deployments = append(deployments, deployment) } @@ -276,7 +274,6 @@ func (p Pipeline) GetDaemonDeploymentObj(req GetDaemonDeploymentReq) (*appv1.Dep {Name: EnvNamespace, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.namespace"}}}, {Name: EnvPod, ValueFrom: &corev1.EnvVarSource{FieldRef: &corev1.ObjectFieldSelector{FieldPath: "metadata.name"}}}, {Name: EnvPipelineObject, Value: encodedPipeline}, - {Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}, } envVars = append(envVars, req.Env...) c := corev1.Container{ @@ -358,9 +355,7 @@ func (p Pipeline) GetDaemonDeploymentObj(req GetDaemonDeploymentReq) (*appv1.Dep } func (p Pipeline) getDaemonPodInitContainer(req GetDaemonDeploymentReq) corev1.Container { - envVars := []corev1.EnvVar{ - {Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}, - } + var envVars []corev1.EnvVar envVars = append(envVars, req.Env...) c := corev1.Container{ Name: CtrInit, diff --git a/pkg/apis/numaflow/v1alpha1/serving_pipeline_types.go b/pkg/apis/numaflow/v1alpha1/serving_pipeline_types.go index c3d96fbb03..8639989b15 100644 --- a/pkg/apis/numaflow/v1alpha1/serving_pipeline_types.go +++ b/pkg/apis/numaflow/v1alpha1/serving_pipeline_types.go @@ -20,7 +20,6 @@ import ( "encoding/base64" "encoding/json" "fmt" - "os" appv1 "k8s.io/api/apps/v1" corev1 "k8s.io/api/core/v1" @@ -437,7 +436,6 @@ func (sp ServingPipeline) buildJetStreamSource(req GetServingPipelineResourceReq func (sp ServingPipeline) getStreamValidationInitContainerSpec(req GetServingPipelineResourceReq) corev1.Container { envVars := []corev1.EnvVar{ {Name: EnvPipelineName, Value: sp.GetPipelineName()}, - {Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}, } envVars = append(envVars, req.Env...) c := corev1.Container{ diff --git a/pkg/apis/numaflow/v1alpha1/vertex_types.go b/pkg/apis/numaflow/v1alpha1/vertex_types.go index 5f218e42d9..70da0def52 100644 --- a/pkg/apis/numaflow/v1alpha1/vertex_types.go +++ b/pkg/apis/numaflow/v1alpha1/vertex_types.go @@ -19,7 +19,6 @@ import ( "encoding/json" "errors" "fmt" - "os" "sort" "strconv" "strings" @@ -418,7 +417,6 @@ func (v Vertex) GetPodSpec(req GetVertexPodSpecReq) (*corev1.PodSpec, error) { func (v Vertex) getInitContainers(req GetVertexPodSpecReq) []corev1.Container { envVars := []corev1.EnvVar{ {Name: EnvPipelineName, Value: v.Spec.PipelineName}, - {Name: EnvGoDebug, Value: os.Getenv(EnvGoDebug)}, } envVars = append(envVars, req.Env...) initContainers := []corev1.Container{