From 46d15af7866b23b28922372ee62f7c0185f1ba39 Mon Sep 17 00:00:00 2001
From: Haider Alshamma <haidera@nulogy.com>
Date: Fri, 6 Sep 2024 16:40:32 -0400
Subject: [PATCH] fix: improve types

---
 src/BrandedNavBar/MobileMenu.tsx         | 5 ++---
 src/BrandedNavBar/NavBarDropdownMenu.tsx | 2 --
 src/Button/ControlIcon.tsx               | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/BrandedNavBar/MobileMenu.tsx b/src/BrandedNavBar/MobileMenu.tsx
index 3003d3990a..41b1b9a231 100644
--- a/src/BrandedNavBar/MobileMenu.tsx
+++ b/src/BrandedNavBar/MobileMenu.tsx
@@ -8,7 +8,6 @@ import { BrandingText } from "../Branding";
 import { DropdownLink, DropdownText } from "../DropdownMenu";
 import { Icon } from "../Icon";
 import { Link } from "../Link";
-import { LinkProps } from "../Link/Link";
 import { addStyledProps } from "../StyledProps";
 import NulogyLogo from "./NulogyLogo";
 import { TriggerFunctionProps } from "./TriggerFunctionProps";
@@ -163,7 +162,7 @@ const getSubMenuHeading = (layer, name) =>
 type ThemeColorObject = {
   textColor?: string;
   background?: string;
-  logoColor?: string;
+  logoColor?: "white" | "blue";
 };
 
 type MenuItem = {
@@ -237,7 +236,7 @@ const BaseMobileMenu: React.FC<React.PropsWithChildren<BaseMobileMenuProps>> = (
 }) => (
   <Nav backgroundColor={themeColorObject && themeColorObject.background} {...props}>
     <BrandingWrap>
-      <BrandingText logoColor={themeColorObject && themeColorObject.logoColor} />
+      <BrandingText logoColor={themeColorObject?.logoColor} />
     </BrandingWrap>
     <Menu>
       {menuData.primaryMenu && renderTopLayerMenuItems(menuData.primaryMenu, closeMenu, themeColorObject)}
diff --git a/src/BrandedNavBar/NavBarDropdownMenu.tsx b/src/BrandedNavBar/NavBarDropdownMenu.tsx
index d5769b0cc3..90501e43a3 100644
--- a/src/BrandedNavBar/NavBarDropdownMenu.tsx
+++ b/src/BrandedNavBar/NavBarDropdownMenu.tsx
@@ -1,5 +1,3 @@
-/* TS IGNORED: due to problems typing propTypes and defaultProps,
-it can stop being ingnored when its refactored to a functional component */
 import React from "react";
 import PropTypes from "prop-types";
 import { Manager, Reference, Popper } from "react-popper";
diff --git a/src/Button/ControlIcon.tsx b/src/Button/ControlIcon.tsx
index 23e23e23fd..a3c3c7954d 100644
--- a/src/Button/ControlIcon.tsx
+++ b/src/Button/ControlIcon.tsx
@@ -5,7 +5,7 @@ import { Icon } from "../Icon";
 
 type ControlIconProps = React.ComponentPropsWithRef<"button"> &
   SpaceProps & {
-    onClick?: (...args: any[]) => any;
+    onClick?: React.MouseEventHandler<HTMLButtonElement>;
     icon: string;
     toggled?: boolean;
     disabled?: boolean;