Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1612: adds separate public key pair for neosync cloud checks #2992

Conversation

nickzelei
Copy link
Member

No description provided.

@nickzelei nickzelei added the enhancement New feature or request label Nov 25, 2024
Copy link

linear bot commented Nov 25, 2024

Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 10:48pm

@nickzelei nickzelei marked this pull request as ready for review November 25, 2024 22:49
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 34.04255% with 62 lines in your changes missing coverage. Please review.

Project coverage is 35.56%. Comparing base (65cc55e) to head (e86920b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/ee/cloud-license/license.go 43.83% 28 Missing and 13 partials ⚠️
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 13 Missing ⚠️
worker/internal/cmds/worker/serve/serve.go 0.00% 6 Missing ⚠️
internal/ee/license/license.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2992       +/-   ##
===========================================
+ Coverage   24.26%   35.56%   +11.29%     
===========================================
  Files         337      337               
  Lines       39120    39189       +69     
===========================================
+ Hits         9494    13939     +4445     
+ Misses      28678    23602     -5076     
- Partials      948     1648      +700     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickzelei nickzelei merged commit 78afd79 into main Nov 26, 2024
10 checks passed
@nickzelei nickzelei deleted the nick/neos-1612-add-separate-public-key-pair-for-neosync-cloud-checks branch November 26, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants