Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEOS-1634: Fixes AnonymizeSingle nil pointer exception on error #2975

Conversation

nickzelei
Copy link
Member

@nickzelei nickzelei commented Nov 21, 2024

  • Fixes nil pointer
  • Pins air in worker/backend dockerfile devs due to go version mismatch
  • adds log for neosync cloud for easier debugging

@nickzelei nickzelei added the bug Something isn't working label Nov 21, 2024
Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
neosync-docs ⬜️ Ignored (Inspect) Visit Preview Nov 21, 2024 7:08pm

Copy link

codecov bot commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 24.50%. Comparing base (f1dfe80) to head (1c90962).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
backend/internal/cmds/mgmt/serve/connect/cmd.go 0.00% 3 Missing ⚠️
...mt/v1alpha1/anonymization-service/anonymization.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f1dfe80) and HEAD (1c90962). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f1dfe80) HEAD (1c90962)
3 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2975       +/-   ##
===========================================
- Coverage   35.02%   24.50%   -10.52%     
===========================================
  Files         330      330               
  Lines       38425    38429        +4     
===========================================
- Hits        13458     9417     -4041     
- Misses      23405    28074     +4669     
+ Partials     1562      938      -624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@nickzelei nickzelei changed the title NEOS-1634: Fixes AnonymizeSingle TransformPiiText nil pointer exception on error NEOS-1634: Fixes AnonymizeSingle nil pointer exception on error Nov 21, 2024
@nickzelei nickzelei force-pushed the nick/neos-1634-investigate-nil-pointer-error-when-calling-anonymizesingle branch from 718ad80 to 1c90962 Compare November 21, 2024 19:10
@nickzelei nickzelei merged commit de249f9 into main Nov 21, 2024
14 of 16 checks passed
@nickzelei nickzelei deleted the nick/neos-1634-investigate-nil-pointer-error-when-calling-anonymizesingle branch November 21, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants