Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEOS-1688] account_id is not needed on ValidateJobMappingsRequest #3067

Open
nickzelei opened this issue Dec 18, 2024 · 0 comments
Open

[NEOS-1688] account_id is not needed on ValidateJobMappingsRequest #3067

nickzelei opened this issue Dec 18, 2024 · 0 comments
Labels
good first issue Good for newcomers Tech Debt Created by Linear-GitHub Sync

Comments

@nickzelei
Copy link
Member

nickzelei commented Dec 18, 2024

it can be inferred from the connection_id. Should be deprecated. and removed in v0.6.

In the mean time, we should mark it as deprecated in the protos and stop passing it around.

The method already calls connectionservice.GetConnection which ensures the calling user is in the connection's account.

We can deprecate the field by adding a comment to the top @deprecated - <explain> as well as adding a [deprecated = true] to the value itself

string account_id = 1 [deprecated = true];

From SyncLinear.com | NEOS-1688

@nickzelei nickzelei added Tech Debt Created by Linear-GitHub Sync good first issue Good for newcomers labels Dec 18, 2024
@nickzelei nickzelei changed the title [NEOS-1688] account_id is not needed on ValidateJobMappings [NEOS-1688] account_id is not needed on ValidateJobMappingsRequest Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Tech Debt Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant