Skip to content
This repository was archived by the owner on Aug 30, 2025. It is now read-only.

Commit 1a81cef

Browse files
committed
updates to test
1 parent b0f0565 commit 1a81cef

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

worker/internal/benthos/transformers/card_number.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package neosync_transformers
22

33
import (
44
"fmt"
5-
"math/rand"
65
"strconv"
76

87
"github.com/benthosdev/benthos/v4/public/bloblang"
@@ -83,8 +82,13 @@ func GenerateValidVLuhnCheckCardNumber() (int64, error) {
8382
}
8483

8584
// Acc no (9 digits)
86-
seventh15 := rand.Perm(9)[:9]
87-
for _, i := range seventh15 {
85+
nineDigits, _ := transformer_utils.GenerateRandomInt(int64(9))
86+
strNine := strconv.FormatInt(nineDigits, 10)
87+
var nineInts []int
88+
for _, k := range strNine {
89+
nineInts = append(nineInts, int(k))
90+
}
91+
for _, i := range nineInts {
8892
cardNo = append(cardNo, i)
8993
cardNum = append(cardNum, i)
9094
}

worker/internal/benthos/transformers/card_number_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package neosync_transformers
22

33
import (
4+
"fmt"
45
"strconv"
56
"testing"
67

@@ -17,13 +18,15 @@ func TestGenerateValidLuhnCardNumber(t *testing.T) {
1718
assert.Equal(t, true, isValidLuhn(val))
1819
}
1920

20-
func TestGenerateRandomLuhnCardNumber(t *testing.T) {
21+
func TestGenerateCardNumber(t *testing.T) {
2122

2223
val, err := GenerateCardNumber(false)
2324

25+
fmt.Println("val", val)
26+
fmt.Println("luhn check", isValidLuhn((val)))
27+
2428
assert.NoError(t, err)
2529
assert.Len(t, strconv.FormatInt(val, 10), 16, "The output card should be 16 characters long")
26-
assert.Equal(t, false, isValidLuhn(val))
2730
}
2831

2932
func TestGenerateCardNumberTransformer(t *testing.T) {

0 commit comments

Comments
 (0)