Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@nteract/transform-vdom latest version is 4.0.16-alpha.0 #48

Open
jasongrout opened this issue Nov 20, 2020 · 3 comments
Open

@nteract/transform-vdom latest version is 4.0.16-alpha.0 #48

jasongrout opened this issue Nov 20, 2020 · 3 comments

Comments

@jasongrout
Copy link

I'm trying to figure out the latest version of @nteract/transform-vdom (which we depend on in JupyterLab).

I notice that on npm:

  • the last non-prerelease version, 4.0.15, was published 2020-03-29T01:06:15.129Z
  • 4.0.16-alpha.0 was published 2020-03-31T01:11:25.025Z
  • 4.0.16-alpha.0 is listed as the latest release on npm, which means it is the default version installed when doing npm install @nteract/transform-vdom
  • I can't find 4.0.16-alpha.0 in this repo

When I compare the actual tarballs on npmjs.com, I see these differences:

% diff -qNaur 4.0.15 4.0.16-alpha.0  
Files 4.0.15/LICENSE and 4.0.16-alpha.0/LICENSE differ
Files 4.0.15/package.json and 4.0.16-alpha.0/package.json differ
Files 4.0.15/tsconfig.json and 4.0.16-alpha.0/tsconfig.json differ
Files 4.0.15/tsconfig.tsbuildinfo and 4.0.16-alpha.0/tsconfig.tsbuildinfo differ

In particular, notice there is no change in the actual js files published, and the only change in the package.json is:

% diff -Naur 4.0.15/package.json 4.0.16-alpha.0/package.json 
--- 4.0.15/package.json	1985-10-26 01:15:00.000000000 -0700
+++ 4.0.16-alpha.0/package.json	1985-10-26 01:15:00.000000000 -0700
@@ -1,6 +1,6 @@
 {
   "name": "@nteract/transform-vdom",
-  "version": "4.0.15",
+  "version": "4.0.16-alpha.0",
   "description": "VDOM Transform for jupyter outputs",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -20,5 +20,6 @@
   "license": "BSD-3-Clause",
   "devDependencies": {
     "@types/lodash.clonedeep": "^4.5.6"
-  }
+  },
+  "gitHead": "8984bec0b7195ad19d5f1b860593df26bd9881f1"
 }

To me, it looks like the latest tag was accidentally set to 4.0.16-alpha.0, and perhaps that prerelease was accidentally published? If this is true, I'd suggest resetting the npmjs.com latest tag with:

npm dist-tag add @nteract/[email protected] latest
@jasongrout
Copy link
Author

jasongrout commented Nov 20, 2020

If I had to guess, based on me doing something similar many times, perhaps 4.0.16-alpha.0 was released by lerna, never committed, and lerna automatically set the latest dist-tag to this pre-release. If that is what happened, you can mitigate the dist-tag setting by using the lerna publish --pre-dist-tag next option, which overrides dist-tag for prereleases: https://github.com/lerna/lerna/tree/main/commands/publish#--pre-dist-tag-tag
This way you always keep latest to be the latest stable release.

@jasongrout
Copy link
Author

FYI, I am looking at this because we upgraded to react 17, but @nteract/transform-vdom still has a peer dependency on react ^16. React 17 seems like a very safe upgrade, though.

@captainsafia
Copy link
Member

Oof! This looks like a fallout from the work we've been doing to move packages out of the monorepo over at nteract/nteract and into their own repos.

To me, it looks like the latest tag was accidentally set to 4.0.16-alpha.0, and perhaps that prerelease was accidentally published? If this is true, I'd suggest resetting the npmjs.com latest tag with

Yeah, I'll give this a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants