Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate sockets before creating channels object #60

Open
todo bot opened this issue Mar 18, 2020 · 0 comments
Open

Validate sockets before creating channels object #60

todo bot opened this issue Mar 18, 2020 · 0 comments
Assignees

Comments

@todo
Copy link

todo bot commented Mar 18, 2020

// TODO: This shouldn't work silently if the socket doesn't actually behave
// like an actual socket
// NOTE: RxJS doesn't error with the fromEvent until there is at least one
// subscriber, which also tells me we might have the wrong behavior
// here as it should go ahead and subscribe unconditionally...
const channels = createMainChannelFromSockets(sockets);


This issue was generated by todo based on a TODO comment in b7d509f. It's been assigned to @captainsafia because they committed the code.
@todo todo bot added the todo 🗒️ label Mar 18, 2020
@captainsafia captainsafia changed the title This shouldn't work silently if the socket doesn't actually behave Validate sockets before creating channels object Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant