Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔊 Audio Resource Management Enhancement #24

Open
rizkifajara opened this issue Nov 14, 2024 · 0 comments
Open

🔊 Audio Resource Management Enhancement #24

rizkifajara opened this issue Nov 14, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rizkifajara
Copy link

Audio Resource Management Enhancement

Hey there, I noticed a few areas where audio resource cleanup could be improved:

Current Implementation (CMIIW)

  1. mediaRecorder.stop() is called when stopping recording
  2. Audio playback is cleaned up with source.stop() and audioContext.close()
  3. URL.createObjectURL() is used for audio blob

Suggested Improvements :

  1. Release media tracks when recording is done:
useEffect(() => {
  return () => {
    if (mediaRecorder) {
      mediaRecorder.stream.getTracks().forEach(track => track.stop());
    }
  };
}, [mediaRecorder, mediaRecorderInitialized]);
  1. Revoke object URLs after use:
URL.revokeObjectURL(audioUrl);

Would these additions be helpful for preventing potential memory leaks?

Labels

  • enhancement
  • performance
@rizkifajara rizkifajara added the bug Something isn't working label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant