Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Page header accent color" as color source flashes color on PDFs #108

Open
nt1m opened this issue Apr 22, 2019 · 1 comment
Open

"Page header accent color" as color source flashes color on PDFs #108

nt1m opened this issue Apr 22, 2019 · 1 comment
Labels
🐞 bug

Comments

@nt1m
Copy link
Owner

nt1m commented Apr 22, 2019

Example: https://poll.qu.edu/images/polling/us/us12192018_ulfj59.pdf/

This is because "Page header accent color" continuously screenshots the 200 top pixels of a page and computes the dominant color which changes as the PDF loads.

I guess I could make sure it only computes the header color once, or take less pixels on top.
@nt1m nt1m added the 🐞 bug label Apr 22, 2019
@nt1m
Copy link
Owner Author

nt1m commented Apr 22, 2019

Hmm, looks like scrolling through the PDF triggers {status: "complete"} tab updates every time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nt1m