Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to use pytest conventions #743

Open
Sherwin-14 opened this issue Jul 2, 2024 · 0 comments
Open

Update integration tests to use pytest conventions #743

Sherwin-14 opened this issue Jul 2, 2024 · 0 comments

Comments

@Sherwin-14
Copy link
Contributor

Sherwin-14 commented Jul 2, 2024

Integration tests have been failing silently for some time (#738). In the course of adding new integration tests (#736), we found some errors that were not reporting very much information, presumably either because the code that's generating the errors are not following pytest conventions.

  1. Tests which import assertions and call for example assertions.assertTrue(x) should be updated to builtin assertions, for example assert x is True.
  2. Tests which do setup at the module level should be updated to use fixtures
@mfisher87 mfisher87 added the bug Something isn't working label Jul 2, 2024
@mfisher87 mfisher87 changed the title Refactor some unit tests Update integration tests to use pytest conventions Jul 2, 2024
@mfisher87 mfisher87 removed the bug Something isn't working label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants