Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

earthaccess.download() ignores errors #581

Open
mfisher87 opened this issue May 21, 2024 · 0 comments
Open

earthaccess.download() ignores errors #581

mfisher87 opened this issue May 21, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mfisher87
Copy link
Member

mfisher87 commented May 21, 2024

We found the pqdm library is the thing swallowing all the error messages. pqdm has an exception_behavior option, which defaults to "ignore", surprisingly. The other two settings, "deferred" and "immediate", are both good options for earthaccess.

@chuckwondo and I agree "immediate" is the most intuitive default, and we can establish a new flag fail_fast: bool = True to override it to "deferred" by passing download(..., fail_fast=False). Prior discussion in #36. Please continue discussion here :)

I feel exposing the "ignore" behavior isn't necessary because the user can do their own exception handling with try.

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant