New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DataTransfers #73

Open

Julusian opened this issue Jan 15, 2020 · 0 comments

Labels

Member

Julusian commented Jan 15, 2020

Summary
During feat: strict tsconfig and use threadedClass #60 all of the connection logic got reviewed, tested and refactored.
This has not yet been done for DataTransfers, so this code could be a bit questionable and has a bunch of TODOs for things to check/test/improve

Tasks:

More unit tests
Review the logic flow in DataLock and the transfer types. Some bits look a bit broken/unused
Handle failed commands data transfers better
Handle waiting for lock in data transfers better

Julusian added the enhancement label

Julusian mentioned this issue

feat: strict tsconfig and use threadedClass #60

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment