Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batching api. To allow for setting multiple supersource boxes in the same packet #140

Open
joelkohler opened this issue Feb 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@joelkohler
Copy link

  • I'm submitting a ...
    [ ] bug report
    [x ] feature request
    [ ] question about the decisions made in the repository
    [ ] question about how to use this project

  • Summary
    I want to make an animated box transition for SuperSources. For the performance I need to set all box parameters from one or all SuperSources at one time.

@Julusian
Copy link
Member

At the protocol level each box is configured as a separate command, but this library may not be allowing for those commands to be sent in the same packets, which is suboptimal.

So I think the solution here is for the currently private sendCommands method to be made public and to be verified to be performant. Then as a user you will have to manually create instantiate the command classes you wish to send and provide them to that method.

Perhaps a 'command batching' api would be nice to have in the future?

@Julusian Julusian added the enhancement New feature or request label Feb 19, 2023
@joelkohler
Copy link
Author

Yes that would be very great.

@Julusian Julusian changed the title Update SuperSource Box Parameters for all Boxes at one time Add batching api to library Sep 25, 2023
@Julusian Julusian changed the title Add batching api to library Add batching api. To allow for setting multiple supersource boxes in the same packet Sep 25, 2023
@Julusian
Copy link
Member

In v3.4.0 it is now possible to batch commands using the sendCommands method, but it requires constructing the command classes manually.
In the future a 'command batching' api can be added to make this easier to achieve

@ifmx-dev
Copy link

It works, thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants