Merge pull request #33 from nrfta/bug/fix-is-test

josemarluedke · web-flow · commit 97c2628431f0 · 2024-11-14T18:21:51.000-03:00
bug: more reliably find out if running in tests
diff --git a/config.go b/config.go
@@ -88,11 +88,12 @@ func unmarshalConfig(config interface{}) error {
 
 func isTesting() bool {
 	for _, arg := range os.Args {
-		if strings.HasPrefix(arg, "-test.v=") {
+		if strings.Contains(arg, "-test") || strings.Contains(arg, ".test") {
 			return true
 		}
 	}
-	return false || os.Getenv("ENV") == "test"
+
+	return os.Getenv("ENV") == "test"
 }
 
 func getMetaConfig(config interface{}) *MetaConfig {

Original file line number	Diff line number	Diff line change
`@@ -88,11 +88,12 @@ func unmarshalConfig(config interface{}) error {`
`88`	`88`
`89`	`89`	`func isTesting() bool {`
`90`	`90`	`for _, arg := range os.Args {`
`91`		`- if strings.HasPrefix(arg, "-test.v=") {`
	`91`	`+ if strings.Contains(arg, "-test") \|\| strings.Contains(arg, ".test") {`
`92`	`92`	`return true`
`93`	`93`	`}`
`94`	`94`	`}`
`95`		`- return false \|\| os.Getenv("ENV") == "test"`
	`95`	`+`
	`96`	`+ return os.Getenv("ENV") == "test"`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`func getMetaConfig(config interface{}) *MetaConfig {`