nrf_802154: Use DPPI and PPIB allocators on nRF54L #19153

NordicBuilder · 2024-11-29T08:57:19Z

Automatically created by action-manifest-pr GH action from PR: nrfconnect/sdk-nrfxlib#1594

The GRTC LPTIMER platform implementation now uses the DPPI and PPIB
allocators provided by NRFX, which avoids conflicts with other modules.

Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>

NordicBuilder · 2024-11-29T08:58:28Z

The following west manifest projects have changed revision in this Pull Request:

Name	Old Revision	New Revision	Diff
nrf-802154	https://github.com/nrfconnect/sdk-nrf-802154/commit/5681104b148c48f9e51b89614fca28357dd0ad5f	https://github.com/nrfconnect/sdk-nrf-802154/commit/b5764deaf3c05fc4343a17ed2ac86e07589af4bb (`main`)	nrfconnect/[email protected]
nrfxlib	nrfconnect/sdk-nrfxlib@`bcab5c5` (`main`)	nrfconnect/sdk-nrfxlib#1594	nrfconnect/sdk-nrfxlib#1594/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

NordicBuilder · 2024-11-29T09:01:20Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 972aeb2c65a5bd47b96826d8a777db0ed5c87974
nrfxlib: PR head: ece3d160465870a457fa76e8b39b34367d0ff6c7

more details

sdk-nrf:

PR head: 972aeb2c65a5bd47b96826d8a777db0ed5c87974
merge base: 148b9567ee91964fc539d8ab38ac3a7a232a9a60
target head (main): 979deabac1e190be04c50415afefe250fc0d3faf
Diff

nrfxlib:

PR head: ece3d160465870a457fa76e8b39b34367d0ff6c7
merge base: bcab5c5f72c8953be2a45c4529e4a70e70ffa6ae
target head (main): bcab5c5f72c8953be2a45c4529e4a70e70ffa6ae
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (21)

modules
│  ├── nrfxlib
│  │  ├── nrf_802154
│  │  │  ├── sl
│  │  │  │  ├── platform
│  │  │  │  │  ├── nrf_802154_platform_sl_lptimer_grtc_hw_task.c
│  │  │  │  │  │ nrf_802154_platform_timestamper.c
nrfxlib
│  ├── nrf_802154
│  │  ├── driver
│  │  │  ├── src
│  │  │  │  │ nrf_802154_peripherals_nrf52.h
│  │  ├── sl
│  │  │  ├── sl
│  │  │  │  ├── include
│  │  │  │  │  │ nrf_802154_sl_periphs.h
│  │  │  │  ├── lib
│  │  │  │  │  ├── nrf54h20_cpurad
│  │  │  │  │  │  ├── hard-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── soft-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── softfp-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  ├── nrf54l15_cpuapp
│  │  │  │  │  │  ├── hard-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── soft-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── softfp-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  ├── nrf54l15_cpuapp_ns
│  │  │  │  │  │  ├── hard-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── soft-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── softfp-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  ├── nrf54l20_cpuapp
│  │  │  │  │  │  ├── hard-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── soft-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── softfp-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  ├── nrf54l20_cpuapp_ns
│  │  │  │  │  │  ├── hard-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── soft-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  │  │  │  │  ├── softfp-float
│  │  │  │  │  │  │  │ libnrf-802154-sl.a
│  │  ├── zephyr
│  │  │  │ Kconfig.nrfxlib
west.yml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 311
✅ Integration tests
- ✅ test-fw-nrfconnect-chip
- ✅ test-fw-nrfconnect-rs
- ✅ test-fw-nrfconnect-fem
- ✅ test-fw-nrfconnect-tfm
- ✅ test-fw-nrfconnect-thread
- ✅ test-fw-nrfconnect-zigbee

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-11-29T09:14:56Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

The GRTC LPTIMER platform implementation now uses the DPPI and PPIB allocators provided by NRFX, which avoids conflicts with other modules. Signed-off-by: Rafał Kuźnia <[email protected]>

ankuns · 2024-11-29T09:44:39Z

modules/nrfxlib/nrf_802154/sl/platform/nrf_802154_platform_timestamper.c

+static uint8_t peri_dppi_ch = -1;
+static uint8_t peri_ppib_ch = -1;


Assigning negative value to uint8_t?

ankuns · 2024-11-29T09:49:46Z

modules/nrfxlib/nrf_802154/sl/platform/nrf_802154_platform_sl_lptimer_grtc_hw_task.c

+	peri_dppi_ch = -1;
+	peri_ppib_ch = -1;


these variables are uint8_t, unsigned

ankuns · 2024-11-29T09:54:25Z

modules/nrfxlib/nrf_802154/sl/platform/nrf_802154_platform_sl_lptimer_grtc_hw_task.c

+static uint8_t peri_dppi_ch = -1;
+static uint8_t peri_ppib_ch = -1;


these variables are uint8_t, unsigned, assigning -1

manifest: Update sdk-nrfxlib revision (auto-manifest PR)

578a50d

Automatically created by Github Action Signed-off-by: Nordic Builder <[email protected]>

NordicBuilder requested a review from a team as a code owner November 29, 2024 08:57

github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Nov 29, 2024

NordicBuilder added manifest-nrfxlib manifest-nrf-802154 DNM labels Nov 29, 2024

modules: nrfxlib: nrf_802154: Use DPPI and PPIB allocators

972aeb2

The GRTC LPTIMER platform implementation now uses the DPPI and PPIB allocators provided by NRFX, which avoids conflicts with other modules. Signed-off-by: Rafał Kuźnia <[email protected]>

e-rk changed the title ~~manifest: sdk-nrfxlib: Update revision of nrf_802154~~ nrf_802154: Use DPPI and PPIB allocators on nRF54L Nov 29, 2024

e-rk requested review from piotrkoziar and ankuns November 29, 2024 09:28

ankuns reviewed Nov 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nrf_802154: Use DPPI and PPIB allocators on nRF54L #19153

nrf_802154: Use DPPI and PPIB allocators on nRF54L #19153

NordicBuilder commented Nov 29, 2024 •

edited by e-rk

Loading

NordicBuilder commented Nov 29, 2024 •

edited

Loading

NordicBuilder commented Nov 29, 2024 •

edited

Loading

NordicBuilder commented Nov 29, 2024

ankuns Nov 29, 2024

ankuns Nov 29, 2024

ankuns Nov 29, 2024

		static uint8_t peri_dppi_ch = -1;
		static uint8_t peri_ppib_ch = -1;

nrf_802154: Use DPPI and PPIB allocators on nRF54L #19153

Are you sure you want to change the base?

nrf_802154: Use DPPI and PPIB allocators on nRF54L #19153

Conversation

NordicBuilder commented Nov 29, 2024 • edited by e-rk Loading

NordicBuilder commented Nov 29, 2024 • edited Loading

NordicBuilder commented Nov 29, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Nov 29, 2024

ankuns Nov 29, 2024

Choose a reason for hiding this comment

ankuns Nov 29, 2024

Choose a reason for hiding this comment

ankuns Nov 29, 2024

Choose a reason for hiding this comment

NordicBuilder commented Nov 29, 2024 •

edited by e-rk

Loading

NordicBuilder commented Nov 29, 2024 •

edited

Loading

NordicBuilder commented Nov 29, 2024 •

edited

Loading