Incorrect wraparound handling #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

chefables-mark opened this issue Nov 6, 2018 · 0 comments

chefables-mark commented Nov 6, 2018

https://github.com/aron-bordin/ArduinoTimerObject/blob/af372e79c3bca2899c07ca1e840a6e8836a48223/TimerObject.cpp#L68

Since you used unsigned variables, the math will work out correctly and you will get correct differences when subtracting across the wraparound.

This code should render your timers invalid when millis() is halfway to max since it will then overflow and have the wrong value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment