Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if you load the screen, and the slide is halfway between two slides, the map doesn't load #153

Open
DanielJWood opened this issue May 8, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@DanielJWood
Copy link
Contributor

in onScroll, this doesn't fire correctly: slideActive = slide;.

I'm. not sure I follow the logic of the following but it should fire on scroll and on load:

    if (
      (isAfterTitleCard && (bounds.top < window.innerHeight && bounds.bottom > 0)) ||
      (!isAfterTitleCard && (bounds.top < window.innerHeight * .9 && bounds.bottom > 0))
      ) {

If the slide is halfway between two screens, it doesn't fire.

slideActive = slide; is fired inside that logic, so if the logic doesn't fire, then the map doesn't fire, on Load.

This is a pretty edgy edge case.

@DanielJWood DanielJWood added the bug Something isn't working label May 8, 2024
@DanielJWood DanielJWood self-assigned this May 8, 2024
@alykat alykat added this to the Y - Pre-launch (week of May 6) milestone May 8, 2024
@DanielJWood DanielJWood added the Priority: High This is of high importance label May 9, 2024
@DanielJWood DanielJWood removed the Priority: High This is of high importance label May 10, 2024
@alykat alykat removed this from the Y - Pre-launch (week of May 6) milestone May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants