Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfying functions don't provide an option to also compare build meta #610

Open
pflannery opened this issue Aug 20, 2023 · 2 comments
Open

Comments

@pflannery
Copy link

Similar to the issue #276.

When using the maxSatisfying function
where the latest version includes build meta data
then maxSatisfying returns a lesser version.

Example

const options = { loose: true, includePrerelease: true };
const releases = [
  '0.1.4',
  '0.1.4+1',
  '0.1.4+2',
  '0.1.4+3',
  '0.1.5',
  '0.1.5+1',
  '0.1.5+2',
];

// returns 0.1.5
maxSatisfying( releases, '0.1.5+2', options );

I can't find a way to utilize the newer compareBuild function when using maxSatisfying.

Is it possible if we can have an additional option like includeBuild so that we can compare builds?

@ailadas

This comment was marked as spam.

@jonmountjoy
Copy link

@pflannery VersionLens already provides a prompt to install the latest version, which works well, and the problem seems only in the comparison of the version installed with the result from maxSatisying. Is it possible for you to add an extra check on the output of maxSatisfying in the case where it's suggested version is equivalent to the current version (except for the build number), where if that's the case, you do an extra check on the build number?

So something like:

// Say I've got the latest version installed
currentInstalledVersion="0.1.5+2"
// As you point out, maxSatisfying will return "0.1.5" which is the problem
var suggestedMax = maxSatisfying(currentInstalledVersion, '0.1.5+2', options)
// So let's do an extra check here
if (isEqual(currentInstalledVersion, suggestedMax ) { // ie. 0.1.5.2 == 0.1.5.2+2
  // Do an extra check on build numbers
  versions = compareBuild(currentInstalledVersion, suggestedMax);
  if (versions > 0) {
   // suggest suggestedMax
  } else {
  // suggest currentInstalledVersion
  }  
} else {
  // proceed as before
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants