-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Forums CRUD #27
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage ? 15.78%
=======================================
Files ? 10
Lines ? 817
Branches ? 0
=======================================
Hits ? 129
Misses ? 678
Partials ? 10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am thinking whether it would be good to merge this together into the group domain, instead of having a folder inside group.
In retrospect, seems like it was a bad idea to include httphandler inside the domain folders (grp, inst, etc). They should be outside since the REST api structure would be different from our domain (use case) methods
Co-authored-by: Qin Guan <[email protected]>
I prefer the small amount of organisation having it in a separate folder gives
Do I create a separate folder for httphandler for forum group and institution |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WIP did not mean to stage files on forumpost
In that case, better to shift outside of the group folder.
No, I'll work on it later |
@tan-yun-e Do you have any changes left planned? |
Are there changes still needed |
No description provided.