Added code for get-subscribers method(Node.js SDK) #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sumitsaurabh927 Have a look here sir |
|
@BiswaViraj awaiting approval/feedback 🙂 |
BiswaViraj
reviewed
Nov 1, 2023
| @@ -1,5 +1,155 @@ | |||
| --- | |||
| openapi: get /v1/subscribers | |||
| openapi: get /v1/subscribers/{subscriberId} | |||
There was a problem hiding this comment.
Suggested change
| openapi: get /v1/subscribers/{subscriberId} | |
| openapi: get /v1/subscribers |
I think this will not need the subscriberId
@sumitsaurabh927 can you confirm this?
There was a problem hiding this comment.
Yes, it is not needed!
|
Also, the function is novu.subscribers.list() and not get :) |
|
Any updates here? @codingis4noobs2 |
|
Hey @unicodeveloper , the suggested changes will be done by today |
codingis4noobs2
force-pushed
the
staging
branch
from
2cb28d8
to
805c804
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #315
Before:
After:
