Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set the CoreNLP client object inside the DocumentProcessor if the language is not supported #23

Open
abhisheknovoic opened this issue Aug 3, 2020 · 0 comments
Open

Do not set the CoreNLP client object inside the DocumentProcessor if the language is not supported #23

abhisheknovoic opened this issue Aug 3, 2020 · 0 comments
Assignees
@abhisheknovoic
Labels
bug Something isn't working

Comments

@abhisheknovoic
Copy link
Contributor

Currently, the CoreNLP object is being set inside the DocumentProcessor regardless of the input language. Set the client only if the language is supported by Stanford CoreNLP list of supported languages.

As of now, the code anyways runs because later when the feature is being requested, we anyways check if the language is supported by CoreNLP or not just before starting the service.
@abhisheknovoic abhisheknovoic added the bug Something isn't working label Aug 3, 2020
@abhisheknovoic abhisheknovoic self-assigned this Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abhisheknovoic abhisheknovoic

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abhisheknovoic