Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic fixes and refactoring #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Logic fixes and refactoring #31

wants to merge 2 commits into from

Conversation

KayDee
Copy link

@KayDee KayDee commented Sep 30, 2018

No description provided.

@rawr51919
Copy link

rawr51919 commented Mar 22, 2019 •
edited
Loading

@KayDee, line 180/197 is actually cleaner how it is right now in master than it is in your PR, as

lastSymbol += word[word.length - 1]; === lastSymbol = word[word.length - 1] + lastSymbol;

I'd like for you to undo that change you put on that line.

@rawr51919 rawr51919 mentioned this pull request Mar 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KayDee @rawr51919