Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin prints error message when trying to process image files #23

Open
chriskinzel opened this issue Jan 2, 2021 · 0 comments
Open

Comments

@chriskinzel
Copy link

🐞 Bug report

Description

The plugin does not automatically ignore image file routes and will instead error out and print an error message to the console during Scully build. The plugin handler is skipped so this does not result in build failure, but the generated error messages are noise in the console.

The ideal behaviour here would be to just skip processing image file routes.

🔬 Minimal Reproduction

Any Scully project using the @notiz/scully-plugin-lazy-images plugin in defaultPostRenderers of the Scully config with a fileHandler plugin registered e.g. registerPlugin('fileHandler', 'png', imageFilePlugin);.

💻Your Environment

Angular Version:



     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 11.0.5
Node: 14.8.0
OS: darwin x64

Angular: 11.0.5
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1100.5
@angular-devkit/build-angular   0.1100.5
@angular-devkit/core            11.0.5
@angular-devkit/schematics      11.0.5
@angular/cdk                    11.0.3
@angular/material               11.0.3
@schematics/angular             11.0.5
@schematics/update              0.1100.5
rxjs                            6.6.3
typescript                      4.0.5

Scully Version:


"@scullyio/init": "^1.0.1"
"@scullyio/ng-lib": "^1.0.0"
"@scullyio/scully": "^1.0.0"
"@notiz/scully-plugin-lazy-images": "^0.3.0"

🔥 Exception or Error


Error during content generation with plugin "lazyImages" for ./projects/website/blog-posts/images/banner.jpg. This hander is skipped.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant