Fix many many join tables #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @maxmousse thanks for fixing the many to many table issue. Yes looks like the DMMF has a new format, because it is an internal API it may cause breaking changes between minor versions. I like the comments, they can be useful when the DMMF changes again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a pull request aiming to fix issue #46 .
I did the next things:
-> Update prisma related packages to the last version.
-> Fix the generation of many many join tables to match the new DMMF format.
-> I let some comments to facilitate the code review. I'll remove them when not usefull anymore.
@marcjulian Let me know if there is something else I can do =)