chore: add errorlint and refactor check error

Author: hoank101

.golangci.yml

@@ -6,6 +6,7 @@ linters:
   disable-all: true
   enable:
     - exportloopref
+    - errorlint
     - errcheck
     - gci
     - goconst

cmd/build_test_matrix/main.go

@@ -97,7 +97,7 @@ func getGithubActionMatrixForTests(e2eRootDirectory, testName string, suite stri
 	fset := token.NewFileSet()
 	err := filepath.Walk(e2eRootDirectory, func(path string, info fs.FileInfo, err error) error {
 		if err != nil {
-			return fmt.Errorf("error walking e2e directory: %s", err)
+			return fmt.Errorf("error walking e2e directory: %w", err)
 		}
 
 		// only look at test files
@@ -107,12 +107,12 @@ func getGithubActionMatrixForTests(e2eRootDirectory, testName string, suite stri
 
 		f, err := parser.ParseFile(fset, path, nil, 0)
 		if err != nil {
-			return fmt.Errorf("failed parsing file: %s", err)
+			return fmt.Errorf("failed parsing file: %w", err)
 		}
 
 		suiteNameForFile, testCases, err := extractSuiteAndTestNames(f)
 		if err != nil {
-			return fmt.Errorf("failed extracting test suite name and test cases: %s", err)
+			return fmt.Errorf("failed extracting test suite name and test cases: %w", err)
 		}
 
 		if testName != "" && contains(testName, testCases) {

docs/docs/03-light-clients/04-wasm/03-integration.md

@@ -105,7 +105,7 @@ func NewSimApp(
       ibcwasmkeeper.NewWasmSnapshotter(app.CommitMultiStore(), &app.WasmClientKeeper),
     )
     if err != nil {
-      panic(fmt.Errorf("failed to register snapshot extension: %s", err))
+      panic(fmt.Errorf("failed to register snapshot extension: %w", err))
     }
   }
   ...

docs/versioned_docs/version-v7.4.x/03-light-clients/04-wasm/03-integration.md

@@ -105,7 +105,7 @@ func NewSimApp(
       ibcwasmkeeper.NewWasmSnapshotter(app.CommitMultiStore(), &app.WasmClientKeeper),
     )
     if err != nil {
-      panic(fmt.Errorf("failed to register snapshot extension: %s", err))
+      panic(fmt.Errorf("failed to register snapshot extension: %w", err))
     }
   }
   ...

docs/versioned_docs/version-v8.2.x/03-light-clients/04-wasm/03-integration.md

@@ -105,7 +105,7 @@ func NewSimApp(
       ibcwasmkeeper.NewWasmSnapshotter(app.CommitMultiStore(), &app.WasmClientKeeper),
     )
     if err != nil {
-      panic(fmt.Errorf("failed to register snapshot extension: %s", err))
+      panic(fmt.Errorf("failed to register snapshot extension: %w", err))
     }
   }
   ...

e2e/dockerutil/dockerutil.go

@@ -28,7 +28,7 @@ func GetTestContainers(ctx context.Context, t *testing.T, dc *dockerclient.Clien
 		),
 	})
 	if err != nil {
-		return nil, fmt.Errorf("failed listing containers: %s", err)
+		return nil, fmt.Errorf("failed listing containers: %w", err)
 	}
 
 	return testContainers, nil
@@ -41,7 +41,7 @@ func GetContainerLogs(ctx context.Context, dc *dockerclient.Client, containerNam
 		ShowStderr: true,
 	})
 	if err != nil {
-		return nil, fmt.Errorf("failed reading logs in test cleanup: %s", err)
+		return nil, fmt.Errorf("failed reading logs in test cleanup: %w", err)
 	}
 	return io.ReadAll(readCloser)
 }

e2e/testsuite/testconfig.go

@@ -683,7 +683,7 @@ func defaultGovv1Beta1ModifyGenesis(version string) func(ibc.ChainConfig, []byte
 
 		govModuleBytes, err := json.Marshal(appStateMap[govtypes.ModuleName])
 		if err != nil {
-			return nil, fmt.Errorf("failed to extract gov genesis bytes: %s", err)
+			return nil, fmt.Errorf("failed to extract gov genesis bytes: %w", err)
 		}
 
 		govModuleGenesisBytes, err := modifyGovv1Beta1AppState(chainConfig, govModuleBytes)
@@ -700,7 +700,7 @@ func defaultGovv1Beta1ModifyGenesis(version string) func(ibc.ChainConfig, []byte
 		if !testvalues.AllowAllClientsWildcardFeatureReleases.IsSupported(version) {
 			ibcModuleBytes, err := json.Marshal(appStateMap[ibcexported.ModuleName])
 			if err != nil {
-				return nil, fmt.Errorf("failed to extract ibc genesis bytes: %s", err)
+				return nil, fmt.Errorf("failed to extract ibc genesis bytes: %w", err)
 			}
 
 			ibcGenesisBytes, err := modifyClientGenesisAppState(ibcModuleBytes)

e2e/testsuite/testsuite.go

@@ -311,10 +311,10 @@ func (s *E2ETestSuite) RecoverRelayerWallets(ctx context.Context, ibcrelayer ibc
 	chainA, chainB := s.GetChains()
 
 	if err := chainA.RecoverKey(ctx, ChainARelayerName, chainARelayerWallet.Mnemonic()); err != nil {
-		return fmt.Errorf("could not recover relayer wallet on chain A: %s", err)
+		return fmt.Errorf("could not recover relayer wallet on chain A: %w", err)
 	}
 	if err := chainB.RecoverKey(ctx, ChainBRelayerName, chainBRelayerWallet.Mnemonic()); err != nil {
-		return fmt.Errorf("could not recover relayer wallet on chain B: %s", err)
+		return fmt.Errorf("could not recover relayer wallet on chain B: %w", err)
 	}
 	return nil
 }

modules/apps/27-interchain-accounts/controller/keeper/genesis.go

@@ -21,7 +21,7 @@ func InitGenesis(ctx sdk.Context, keeper Keeper, state genesistypes.ControllerGe
 
 			// use the controller scoped keeper to claim the port capability
 			if err := keeper.ClaimCapability(ctx, capability, host.PortPath(portID)); err != nil {
-				panic(fmt.Errorf("could not claim port capability: %v", err))
+				panic(fmt.Errorf("could not claim port capability: %w", err))
 			}
 		}
 	}

modules/apps/27-interchain-accounts/host/keeper/genesis.go

@@ -21,7 +21,7 @@ func InitGenesis(ctx sdk.Context, keeper Keeper, state genesistypes.HostGenesisS
 
 		// use the host scoped keeper to claim the port capability
 		if err := keeper.ClaimCapability(ctx, capability, host.PortPath(state.Port)); err != nil {
-			panic(fmt.Errorf("could not claim port capability: %v", err))
+			panic(fmt.Errorf("could not claim port capability: %w", err))
 		}
 	}
 
@@ -34,7 +34,7 @@ func InitGenesis(ctx sdk.Context, keeper Keeper, state genesistypes.HostGenesisS
 	}
 
 	if err := state.Params.Validate(); err != nil {
-		panic(fmt.Errorf("could not set ica host params at genesis: %v", err))
+		panic(fmt.Errorf("could not set ica host params at genesis: %w", err))
 	}
 	keeper.SetParams(ctx, state.Params)
 }