Remove EnsureRegistrationOnCurrentUser, since it is no longer needed

Author: GurliGebis

Installer.cpp

@@ -403,46 +403,6 @@ HRESULT NppShell::Installer::Uninstall()
     return S_OK;
 }
 
-void EnsureRegistrationOnCurrentUserWorker()
-{
-    // Initialize the WinRT apartment.
-    winrt::init_apartment();
-
-    // Get the package to check if it is already installed for the current user.
-    Package existingPackage = GetSparsePackage();
-
-    if (existingPackage == NULL)
-    {
-        // The package is not installed for the current user - but we know that Notepad++ is.
-        // If it wasn't, this code wouldn't be running, so it is safe to just register the package.
-        RegisterSparsePackage();
-
-        // Finally we notify the shell that we have made changes, so it reloads the right click menu items.
-        SHChangeNotify(SHCNE_ASSOCCHANGED, SHCNF_IDLIST, 0, 0);
-    }
-}
-
-void NppShell::Installer::EnsureRegistrationOnCurrentUser()
-{
-    // First we find the name of the process the DLL is being loaded into.
-    wstring moduleName = GetExecutingModuleName();
-
-    if (moduleName == L"explorer.exe")
-    {
-        const bool isWindows11 = IsWindows11Installation();
-
-        if (isWindows11)
-        {
-            // We are being loaded into explorer.exe, so we can continue.
-            // Explorer.exe only loads the DLL on the first time a user right-clicks a file
-            // after that it stays in memory for the rest of their session.
-            // Since we are here, we spawn a thread and call the EnsureRegistrationOnCurrentUserWorker function.
-            thread ensureRegistrationThread = thread(EnsureRegistrationOnCurrentUserWorker);
-            ensureRegistrationThread.detach();
-        }
-    }
-}
-
 STDAPI CleanupDll()
 {
     // First we get the full path to this DLL.

Installer.h

@@ -11,8 +11,6 @@ namespace NppShell::Installer
 
     HRESULT Install();
     HRESULT Uninstall();
-
-    void EnsureRegistrationOnCurrentUser();
 }
 
 STDAPI CleanupDll();

dllmain.cpp

@@ -21,7 +21,6 @@ BOOL APIENTRY DllMain(HMODULE hModule, DWORD  ul_reason_for_call, LPVOID lpReser
     {
         case DLL_PROCESS_ATTACH:
             g_module = hModule;
-            NppShell::Installer::EnsureRegistrationOnCurrentUser();
             break;
         case DLL_THREAD_ATTACH:
         case DLL_THREAD_DETACH: