Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: supporting Sign/Verify with multiple images #62

Merged
merged 13 commits into from
Jul 2, 2024
Merged

feat: supporting Sign/Verify with multiple images #62

merged 13 commits into from
Jul 2, 2024

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jun 27, 2024 •
edited
Loading

This PR updates the sign and verify actions to accept a list of target artifact references. Tests are also included in this PR.

Resolves #59
Resolves #48

@Two-Hearts
sign multiple artifacts
b4f808a 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
sign multiple artifacts
bc8ce91 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
462e512 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
4d2822b 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
27e341e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
587a244 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
d33ab1e 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
d7a9cdd 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
rebuild
8c92690 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated verify
e53cacf 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts
updated verify
61a228d 
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts changed the title feat: supporting Sign multiple images feat: supporting Sign/Verify with multiple images Jul 1, 2024
@Two-Hearts
clean up
71cd268 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT reviewed Jul 1, 2024
View reviewed changes
sign/action.yml Outdated Show resolved Hide resolved
verify/action.yml Outdated Show resolved Hide resolved
@Two-Hearts
clean up
b3290c1 
Signed-off-by: Patrick Zheng <[email protected]>
shizhMSFT
shizhMSFT approved these changes Jul 2, 2024
View reviewed changes
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Two-Hearts Two-Hearts merged commit 78caa37 into notaryproject:main Jul 2, 2024
6 checks passed
@Two-Hearts Two-Hearts deleted the feat branch July 2, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@duffney duffney Awaiting requested review from duffney duffney is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@priteshbandi priteshbandi Awaiting requested review from priteshbandi priteshbandi is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support signing multiple images at once Plugin_config is undocumented
2 participants
@Two-Hearts @shizhMSFT