Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defcomponent API is very confusing #59

Open
p-himik opened this issue Aug 1, 2019 · 1 comment
Open

defcomponent API is very confusing #59

p-himik opened this issue Aug 1, 2019 · 1 comment

Comments

@p-himik
Copy link

p-himik commented Aug 1, 2019

defcomponent requires the first function to behave like a constructor but it doesn't check its name and argument list.
At the same time, React itself does not require an explicit constructor for class components.

@lilactown
Copy link
Collaborator

Agreed. defcomponent has not received much love, as I have only needed it for very small things like creating a general ErrorBoundary component.

Removing the need for an explicit constructor would be good just to remove the surprise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants