Won't Import Spansh CSV

[Wombat1501]

As the title says. Say the file is not a valid file.

[KitsuneNoBaka]

It imports Road2Riches spansh cvs, but not Road2Exobiology

Road2Riches CVS
"System Name","Body Name","Body Subtype","Is Terraformable","Distance To Arrival","Estimated Scan Value","Estimated Mapping Value","Jumps" "BD+33 4395","BD+33 4395 A 1","Water world","Yes","304.295127","274004","995547","2" "HIP 114458","HIP 114458 A 2","Earth-like world","No","346.979084","266717","969071","2" "HIP 104179","HIP 104179 4","High metal content world","Yes","491.518702","191221","694769","3" "HIP 104179","HIP 104179 5","High metal content world","Yes","880.225912","188695","685591","0" "HIP 16887","HIP 16887 1","Water world","Yes","445.113266","275451","1000804","5"

Road2Exobiology
"System Name","Body Name","Body Subtype","Distance To Arrival","Landmark Subtype","Value","Count","Jumps" "Sesuang","Sesuang A 6","Icy body","288.154661","Fonticulua Fluctus","20000000","20","1" "Borfor","Borfor 1 c","Rocky body","762.982748","Cactoida Vermis","16202800","20","2" "Borfor","Borfor 1 d","Rocky body","767.200511","Cactoida Vermis","16202800","20","0" "Borfor","Borfor 1 b","Rocky body","768.64627","Cactoida Vermis","16202800","20","0" "HIP 82068","HIP 82068 5 c","Rocky body","786.262387","Cactoida Vermis","16202800","20","3" "Daruwutja","Daruwutja B 5","High metal content world","760.642688","Stratum Tectonicas","19010800","20","5" "Daruwutja","Daruwutja B 4","High metal content world","781.991118","Stratum Tectonicas","19010800","20","0"

[Sigtrap2074]

I'm having similar issues. I can import neutron plots without problem, but I've been trying to import a Spansh Ammonia Worlds route, to no avail.

[Wombat1501]

The problem seems to be the different formats for each planner. I guess this is neccesary because they all do differemt things. perhaps Spansh could standardise the parts used bt the Spansh Router or if we knew what the Spansh Router was looking for maybe we could modify the exported CSV to suit?

…

________________________________ From: Sigtrap2074 ***@***.***> Sent: Friday, 3 March 2023 4:02 PM To: norohind/EDMC_SpanshRouter ***@***.***> Cc: Wombat1501 ***@***.***>; State change ***@***.***> Subject: Re: [norohind/EDMC_SpanshRouter] Won't Import Spansh CSV (Issue #1) I'm having similar issues. I can import neutron plots without problem, but I've been trying to import a Spansh Ammonia Worlds route, to no avail. — Reply to this email directly, view it on GitHub<https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnorohind%2FEDMC_SpanshRouter%2Fissues%2F1%23issuecomment-1452977104&data=05%7C01%7C%7Ce5a1fd5b7ed84be23f2608db1ba47e87%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638134165541856946%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Y2oFoC53NIKbz4tJkY4K3Ohktgi%2FfEPyEmpWgEgnGdE%3D&reserved=0>, or unsubscribe<https://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FANESCDIV3OZ5F3QFR7TK3LTW2F3ONANCNFSM6AAAAAAVAURACI&data=05%7C01%7C%7Ce5a1fd5b7ed84be23f2608db1ba47e87%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C638134165541856946%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Vw2oO6ZAkuq%2FWMcmzNabVrmG8DiJxv368OjZhgPnzDI%3D&reserved=0>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

[Artoria2e5]

The router is looking for the exact road2riches header:

EDMC_SpanshRouter/SpanshRouter/SpanshRouter.py

Line 449 in 00182da

road2richesimportheader = "System Name,Body Name,Body Subtype,Is Terraformable,Distance To Arrival,Estimated Scan Value,Estimated Mapping Value,Jumps"

EDMC_SpanshRouter/SpanshRouter/SpanshRouter.py

Line 492 in 00182da

elif headerline == road2richesimportheader:

It only takes the information in body name, subtype, and the usual system and jumps columns. All these columns are also present in the Road2Exobiology CSV.

For a band-aid fix, just add this below the first linked line,

road2exoimportheader = "System Name,Body Name,Body Subtype,Distance To Arrival,Landmark Subtype,Value,Count,Jumps"

and change the second linked line to

elif (headerline == road2richesimportheader) or (headerline == road2exoimportheader):

For a long-term fix (assuming Frontier adds ANOTHER thing that makes you scan planets and spansh makes another roads to X -- unlikely lol), this thing should not be matching exact headers, but just checking for whether column titles exist.

[norohind]

Hello, guys. For some reason I wasn't receiving notifications from this repo, I'm sorry for such long respond time.
I agree the code for csv parsing should be more unified than it is now. However, I don't currently play ED much so probably won't get my hands to fix it.
I have just merged a PR #3 which declares support for routes by galaxy plotter. Please feel free to test if it's so. Others PRs are welcome.
If you have a better fork of original project, I can specify link to it in README and archive this repo.