Timeout is fake?

[Cookiery]

Even if I add use the context.WithTimeout, but it does not effective

[dbarrosop]

It is not fake but is left to be considered by the underlying task (SSHOpen) in your example, which seems to not be honoring it. Feel free to submit a PR fixing the issue.

[Cookiery]

OK, I will consider how to solve this problem and submit a PR fixing the issue.

[Cookiery]

Thanks for your reply!

[nleiva]

Looks like ssh.Dial doesn't take a context, which is what this package use:

https://github.com/nornir-automation/gornir/blob/master/pkg/plugins/connection/ssh.go#L72-L77

	client, err := ssh.Dial("tcp", fmt.Sprintf("%s:%d", host.Hostname, port), config)
	if err != nil {
		return &SSH{}, errors.Wrap(err, "failed to dial")
	}
	host.SetConnection("ssh", &SSH{client})
	return &SSH{client}, nil

Maybe a solution is what they describe here: golang/go#20288 (comment). In a nutshell, create a new Dial function in this package with a context which you can use instead.

func Dial(ctx context.Context, network, addr string, config *ssh.ClientConfig) (*ssh.Client, error) {
	d := net.Dialer{Timeout: config.Timeout}
	conn, err := d.DialContext(ctx, network, addr)
	if err != nil {
		return nil, err
	}
	c, chans, reqs, err := ssh.NewClientConn(conn, addr, config)
	if err != nil {
		return nil, err
	}
	return ssh.NewClient(c, chans, reqs), nil
}