Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Proportional' encumbrance is not proportional #167

Open
RenechCDDA opened this issue Jan 25, 2024 · 2 comments
Open

'Proportional' encumbrance is not proportional #167

RenechCDDA opened this issue Jan 25, 2024 · 2 comments

Comments

@RenechCDDA
Copy link

Following up on #163 (comment) ....

Here's two items from HHG, both say they have 10 encumbrance. armor_acidchitin copies from armor_chitin with a proportional encumbrance of 1.5 (50% more), but HHG doesn't recognize that.

https://cdda-guide.nornagon.net/item/armor_chitin

https://cdda-guide.nornagon.net/item/armor_acidchitin

And ingame:

image

image

@nornagon
Copy link
Owner

hm, it looks like currently in the data, armor_acidchitin doesn't have a proportional encumbrance specified: https://github.com/CleverRaven/Cataclysm-DDA/blob/cdda-experimental-2024-09-22-0113/data/json/items/armor/suits_protection.json#L78-L89

but i can definitely believe the Guide doesn't interpret this correctly!

@nornagon
Copy link
Owner

boots_western has proportional encumbrance of 2 over boots:

https://github.com/CleverRaven/Cataclysm-DDA/blob/03763473c2ae6d4e559306c74099890d306a8211/data/json/items/armor/boots.json#L991

but they display the same encumbrance in the Guide, so that'll be easier to test this bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants