Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad_plugin.yaml is missing in pip installed package #11

Open
markus1978 opened this issue Apr 8, 2024 · 5 comments
Open

nomad_plugin.yaml is missing in pip installed package #11

markus1978 opened this issue Apr 8, 2024 · 5 comments

Comments

@markus1978
Copy link
Member

When you pip install, e.g.:

pip install git+https://github.com/nomad-coe/nomad-schema-plugin-example@main

The nomadschemaexample/nomad_plugin.yaml is not copied to the install folder (e.g. ...python3.9/site-packages/nomadschemaexample/). Without the file the plugin cannot be used.

@schumannj has this problem in her fork too: https://github.com/schumannj/nomad-schema-plugin-fhi-catalysis

For some reason it works for other projects (e.g. https://github.com/FAIRmat-NFDI/nomad-measurements) it works fine. Weirdly enough, the seemingly relevant parts of the respective pyproject.tomls look the same.

@markus1978
Copy link
Member Author

@blueraft please have a look as soon as you can. This is currently failing our example oasis deployment, because it includes @schumannj 's plugin.

If you have a solution, please also open a PR for https://github.com/schumannj/nomad-schema-plugin-fhi-catalysis.

@markus1978
Copy link
Member Author

@lauri-codes this is the cause for the example oasis deployment failing.

@markus1978
Copy link
Member Author

@hampusnasstrom Maybe you know more? For your measurments and materials processing plugins the nomad_plugin.yaml gets installed properly.

@blueraft
Copy link
Contributor

blueraft commented Apr 8, 2024

I've created a PR for this in this repo. Once it gets merged, I can create a PR in fhi-catalysis repo.

@hampusnasstrom
Copy link

Seems like Ahmed solved this? But I did have some issues with this for installing a plugin that's not at the top level of a github repository. However, adding a MANIFEST.in solved this so I usually add one now with the line:

recursive-include * nomad_plugin.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants