Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some problem in scripts directory related to two launch files #13

Closed
ataeiamirhosein opened this issue Nov 10, 2020 · 7 comments
Closed

Comments

@ataeiamirhosein
Copy link

ataeiamirhosein commented Nov 10, 2020

hello;
I am a master student of telecom in Politecnico di Milano under the supervision of prof. Giacomo Verticale and we work on this platform and edited some section that I described...

in file launch_agent.py I change some lines as below:

add from sacred.observers import MongoObserver after from sacred import Experiment for running like MongoDB observer.

in file launch_q_learn_umts_olpc.py I changed some lines as below:

  • also, add from sacred.observers import MongoObserver after from sacred import Experiment for running like MongoDB observer.
  • we have a problem with the done parameter in loop so change;
if done:
    break

to

if s == num_episodes:
    break

in the section of # Collect progress because done not execute and we ran into out dimension.

  • in the section of # Plot results we actually do not need the first plot.figure()

thanks

@alvarovalcarce
Copy link
Collaborator

Hi,
yes, you can add MongoDB observers if you want.

What is exactly the problem with the done parameter?

@ataeiamirhosein
Copy link
Author

ataeiamirhosein commented Nov 10, 2020

actually in the file of launch_q_learn_umts_olpc.py when running the code

if done:
    break

not execute and not break the code. so, I get an error about the dimension control

@alvarovalcarce
Copy link
Collaborator

Seems to be related to max_steps_per_episode in that script. I've changed that. Can you please pull and try again?

@ataeiamirhosein
Copy link
Author

ataeiamirhosein commented Nov 12, 2020

sure
i will tell you asap

@ataeiamirhosein
Copy link
Author

I try again and this time problem was solved
perfect
can you please describe about your changes?

@alvarovalcarce
Copy link
Collaborator

I just read avoided that t_max is read from the json configuration file by default (see the commit). You can, of course, change this if you need.

@ataeiamirhosein
Copy link
Author

ataeiamirhosein commented Nov 16, 2020

nice
yes, i got it
i wanna work on some new environment and agent
thanks a lot for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants